Address review comments - rename toHash to nonNegativeHash

core/src/main/scala/org/apache/spark/network/netty/ShuffleSender.scala

@@ -58,7 +58,7 @@ private[spark] object ShuffleSender {
           throw new Exception("Block " + blockId + " is not a shuffle block")
         }
         // Figure out which local directory it hashes to, and which subdirectory in that
-        val hash = Utils.toHash(blockId)
+        val hash = Utils.nonNegativeHash(blockId)
         val dirId = hash % localDirs.length
         val subDirId = (hash / localDirs.length) % subDirsPerLocalDir
         val subDir = new File(localDirs(dirId), "%02x".format(subDirId))

core/src/main/scala/org/apache/spark/storage/DiskStore.scala

@@ -238,7 +238,7 @@ private class DiskStore(blockManager: BlockManager, rootDirs: String)
     logDebug("Getting file for block " + blockId)
 
     // Figure out which local directory it hashes to, and which subdirectory in that
-    val hash = Utils.toHash(blockId)
+    val hash = Utils.nonNegativeHash(blockId)
     val dirId = hash % localDirs.length
     val subDirId = (hash / localDirs.length) % subDirsPerLocalDir
 

core/src/main/scala/org/apache/spark/util/Utils.scala

@@ -780,7 +780,7 @@ private[spark] object Utils extends Logging {
   }
 
   // Handles idiosyncracies with hash (add more as required)
-  def toHash(obj: AnyRef): Int = {
+  def nonNegativeHash(obj: AnyRef): Int = {
 
     // Required ?
     if (obj eq null) return 0