Skip to content
Snippets Groups Projects
Commit 0be071ab authored by Reynold Xin's avatar Reynold Xin
Browse files

Merge pull request #756 from cdshines/patch-1

Refactored Vector.apply(length, initializer) replacing excessive code with library method
parents 12553e5c 0c655371
No related branches found
No related tags found
No related merge requests found
......@@ -73,7 +73,6 @@ class Vector(val elements: Array[Double]) extends Serializable {
def += (other: Vector): Vector = {
if (length != other.length)
throw new IllegalArgumentException("Vectors of different length")
var ans = 0.0
var i = 0
while (i < length) {
elements(i) += other(i)
......@@ -117,9 +116,7 @@ object Vector {
def apply(elements: Double*) = new Vector(elements.toArray)
def apply(length: Int, initializer: Int => Double): Vector = {
val elements = new Array[Double](length)
for (i <- 0 until length)
elements(i) = initializer(i)
val elements: Array[Double] = Array.tabulate(length)(initializer)
return new Vector(elements)
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment