Skip to content
Snippets Groups Projects
  • Stefan Schulze's avatar
    4775eb41
    [SPARK-16770][BUILD] Fix JLine dependency management and version (Sca… · 4775eb41
    Stefan Schulze authored
    ## What changes were proposed in this pull request?
    As of Scala 2.11.x there is no longer a org.scala-lang:jline version aligned to the scala version itself. Scala console now uses the plain jline:jline module. Spark's  dependency management did not reflect this change properly, causing Maven to pull in Jline via transitive dependency. Unfortunately Jline 2.12 contained a minor but very annoying bug rendering the shell almost useless for developers with german keyboard layout. This request contains the following chages:
    - Exclude transitive dependency 'jline:jline' from hive-exec module
    - Remove global properties 'jline.version' and 'jline.groupId'
    - Add both properties and dependency to 'scala-2.11' profile
    - Add explicit dependency on 'jline:jline' to  module 'spark-repl'
    
    ## How was this patch tested?
    - Running mvn dependency:tree and checking for correct Jline version 2.12.1
    - Running full builds with assembly and checking for jline-2.12.1.jar in 'lib' folder of generated tarball
    
    Author: Stefan Schulze <stefan.schulze@pentasys.de>
    
    Closes #14429 from stsc-pentasys/SPARK-16770.
    4775eb41
    History
    [SPARK-16770][BUILD] Fix JLine dependency management and version (Sca…
    Stefan Schulze authored
    ## What changes were proposed in this pull request?
    As of Scala 2.11.x there is no longer a org.scala-lang:jline version aligned to the scala version itself. Scala console now uses the plain jline:jline module. Spark's  dependency management did not reflect this change properly, causing Maven to pull in Jline via transitive dependency. Unfortunately Jline 2.12 contained a minor but very annoying bug rendering the shell almost useless for developers with german keyboard layout. This request contains the following chages:
    - Exclude transitive dependency 'jline:jline' from hive-exec module
    - Remove global properties 'jline.version' and 'jline.groupId'
    - Add both properties and dependency to 'scala-2.11' profile
    - Add explicit dependency on 'jline:jline' to  module 'spark-repl'
    
    ## How was this patch tested?
    - Running mvn dependency:tree and checking for correct Jline version 2.12.1
    - Running full builds with assembly and checking for jline-2.12.1.jar in 'lib' folder of generated tarball
    
    Author: Stefan Schulze <stefan.schulze@pentasys.de>
    
    Closes #14429 from stsc-pentasys/SPARK-16770.