Skip to content
Snippets Groups Projects
  • hyukjinkwon's avatar
    7c7bc8fc
    [SPARK-21189][INFRA] Handle unknown error codes in Jenkins rather then leaving... · 7c7bc8fc
    hyukjinkwon authored
    [SPARK-21189][INFRA] Handle unknown error codes in Jenkins rather then leaving incomplete comment in PRs
    
    ## What changes were proposed in this pull request?
    
    Recently, Jenkins tests were unstable due to unknown reasons as below:
    
    ```
     /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-r ; process was terminated by signal 9
        test_result_code, test_result_note = run_tests(tests_timeout)
      File "./dev/run-tests-jenkins.py", line 140, in run_tests
        test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
    KeyError: -9
    ```
    
    ```
    Traceback (most recent call last):
      File "./dev/run-tests-jenkins.py", line 226, in <module>
        main()
      File "./dev/run-tests-jenkins.py", line 213, in main
        test_result_code, test_result_note = run_tests(tests_timeout)
      File "./dev/run-tests-jenkins.py", line 140, in run_tests
        test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
    KeyError: -10
    ```
    
    This exception looks causing failing to update the comments in the PR. For example:
    
    ![2017-06-23 4 19 41](https://user-images.githubusercontent.com/6477701/27470626-d035ecd8-582f-11e7-883e-0ae6941659b7.png)
    
    ![2017-06-23 4 19 50](https://user-images.githubusercontent.com/6477701/27470629-d11ba782-582f-11e7-97e0-64d28cbc19aa.png)
    
    these comment just remain.
    
    This always requires, for both reviewers and the author, a overhead to click and check the logs, which I believe are not really useful.
    
    This PR proposes to leave the code in the PR comment messages and let update the comments.
    
    ## How was this patch tested?
    
    Jenkins tests below, I manually gave the error code to test this.
    
    Author: hyukjinkwon <gurwls223@gmail.com>
    
    Closes #18399 from HyukjinKwon/jenkins-print-errors.
    7c7bc8fc
    History
    [SPARK-21189][INFRA] Handle unknown error codes in Jenkins rather then leaving...
    hyukjinkwon authored
    [SPARK-21189][INFRA] Handle unknown error codes in Jenkins rather then leaving incomplete comment in PRs
    
    ## What changes were proposed in this pull request?
    
    Recently, Jenkins tests were unstable due to unknown reasons as below:
    
    ```
     /home/jenkins/workspace/SparkPullRequestBuilder/dev/lint-r ; process was terminated by signal 9
        test_result_code, test_result_note = run_tests(tests_timeout)
      File "./dev/run-tests-jenkins.py", line 140, in run_tests
        test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
    KeyError: -9
    ```
    
    ```
    Traceback (most recent call last):
      File "./dev/run-tests-jenkins.py", line 226, in <module>
        main()
      File "./dev/run-tests-jenkins.py", line 213, in main
        test_result_code, test_result_note = run_tests(tests_timeout)
      File "./dev/run-tests-jenkins.py", line 140, in run_tests
        test_result_note = ' * This patch **fails %s**.' % failure_note_by_errcode[test_result_code]
    KeyError: -10
    ```
    
    This exception looks causing failing to update the comments in the PR. For example:
    
    ![2017-06-23 4 19 41](https://user-images.githubusercontent.com/6477701/27470626-d035ecd8-582f-11e7-883e-0ae6941659b7.png)
    
    ![2017-06-23 4 19 50](https://user-images.githubusercontent.com/6477701/27470629-d11ba782-582f-11e7-97e0-64d28cbc19aa.png)
    
    these comment just remain.
    
    This always requires, for both reviewers and the author, a overhead to click and check the logs, which I believe are not really useful.
    
    This PR proposes to leave the code in the PR comment messages and let update the comments.
    
    ## How was this patch tested?
    
    Jenkins tests below, I manually gave the error code to test this.
    
    Author: hyukjinkwon <gurwls223@gmail.com>
    
    Closes #18399 from HyukjinKwon/jenkins-print-errors.