Skip to content
Snippets Groups Projects
  • Reynold Xin's avatar
    3134c3fe
    [SPARK-6953] [PySpark] speed up python tests · 3134c3fe
    Reynold Xin authored
    This PR try to speed up some python tests:
    
    ```
    tests.py                       144s -> 103s      -41s
    mllib/classification.py         24s -> 17s        -7s
    mllib/regression.py             27s -> 15s       -12s
    mllib/tree.py                   27s -> 13s       -14s
    mllib/tests.py                  64s -> 31s       -33s
    streaming/tests.py             185s -> 84s      -101s
    ```
    Considering python3, the total saving will be 558s (almost 10 minutes) (core, and streaming run three times, mllib runs twice).
    
    During testing, it will show used time for each test file:
    ```
    Run core tests ...
    Running test: pyspark/rdd.py ... ok (22s)
    Running test: pyspark/context.py ... ok (16s)
    Running test: pyspark/conf.py ... ok (4s)
    Running test: pyspark/broadcast.py ... ok (4s)
    Running test: pyspark/accumulators.py ... ok (4s)
    Running test: pyspark/serializers.py ... ok (6s)
    Running test: pyspark/profiler.py ... ok (5s)
    Running test: pyspark/shuffle.py ... ok (1s)
    Running test: pyspark/tests.py ... ok (103s)   144s
    ```
    
    Author: Reynold Xin <rxin@databricks.com>
    Author: Xiangrui Meng <meng@databricks.com>
    
    Closes #5605 from rxin/python-tests-speed and squashes the following commits:
    
    d08542d [Reynold Xin] Merge pull request #14 from mengxr/SPARK-6953
    89321ee [Xiangrui Meng] fix seed in tests
    3ad2387 [Reynold Xin] Merge pull request #5427 from davies/python_tests
    3134c3fe
    History
    [SPARK-6953] [PySpark] speed up python tests
    Reynold Xin authored
    This PR try to speed up some python tests:
    
    ```
    tests.py                       144s -> 103s      -41s
    mllib/classification.py         24s -> 17s        -7s
    mllib/regression.py             27s -> 15s       -12s
    mllib/tree.py                   27s -> 13s       -14s
    mllib/tests.py                  64s -> 31s       -33s
    streaming/tests.py             185s -> 84s      -101s
    ```
    Considering python3, the total saving will be 558s (almost 10 minutes) (core, and streaming run three times, mllib runs twice).
    
    During testing, it will show used time for each test file:
    ```
    Run core tests ...
    Running test: pyspark/rdd.py ... ok (22s)
    Running test: pyspark/context.py ... ok (16s)
    Running test: pyspark/conf.py ... ok (4s)
    Running test: pyspark/broadcast.py ... ok (4s)
    Running test: pyspark/accumulators.py ... ok (4s)
    Running test: pyspark/serializers.py ... ok (6s)
    Running test: pyspark/profiler.py ... ok (5s)
    Running test: pyspark/shuffle.py ... ok (1s)
    Running test: pyspark/tests.py ... ok (103s)   144s
    ```
    
    Author: Reynold Xin <rxin@databricks.com>
    Author: Xiangrui Meng <meng@databricks.com>
    
    Closes #5605 from rxin/python-tests-speed and squashes the following commits:
    
    d08542d [Reynold Xin] Merge pull request #14 from mengxr/SPARK-6953
    89321ee [Xiangrui Meng] fix seed in tests
    3ad2387 [Reynold Xin] Merge pull request #5427 from davies/python_tests
run-tests 5.08 KiB
#!/usr/bin/env bash

#
# Licensed to the Apache Software Foundation (ASF) under one or more
# contributor license agreements.  See the NOTICE file distributed with
# this work for additional information regarding copyright ownership.
# The ASF licenses this file to You under the Apache License, Version 2.0
# (the "License"); you may not use this file except in compliance with
# the License.  You may obtain a copy of the License at
#
#    http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
#


# Figure out where the Spark framework is installed
FWDIR="$(cd "`dirname "$0"`"; cd ../; pwd)"

. "$FWDIR"/bin/load-spark-env.sh

# CD into the python directory to find things on the right path
cd "$FWDIR/python"

FAILED=0
LOG_FILE=unit-tests.log
START=$(date +"%s")

rm -f $LOG_FILE

# Remove the metastore and warehouse directory created by the HiveContext tests in Spark SQL
rm -rf metastore warehouse

function run_test() {
    echo -en "Running test: $1 ... " | tee -a $LOG_FILE
    start=$(date +"%s")
    SPARK_TESTING=1 time "$FWDIR"/bin/pyspark $1 > $LOG_FILE 2>&1

    FAILED=$((PIPESTATUS[0]||$FAILED))

    # Fail and exit on the first test failure.
    if [[ $FAILED != 0 ]]; then
        cat $LOG_FILE | grep -v "^[0-9][0-9]*" # filter all lines starting with a number.
        echo -en "\033[31m"  # Red
        echo "Had test failures; see logs."
        echo -en "\033[0m"  # No color
        exit -1
    else
        now=$(date +"%s")
        echo "ok ($(($now - $start))s)"
    fi
}

function run_core_tests() {
    echo "Run core tests ..."
    run_test "pyspark/rdd.py"
    run_test "pyspark/context.py"
    run_test "pyspark/conf.py"
    PYSPARK_DOC_TEST=1 run_test "pyspark/broadcast.py"
    PYSPARK_DOC_TEST=1 run_test "pyspark/accumulators.py"
    run_test "pyspark/serializers.py"
    run_test "pyspark/profiler.py"
    run_test "pyspark/shuffle.py"
    run_test "pyspark/tests.py"
}

function run_sql_tests() {
    echo "Run sql tests ..."
    run_test "pyspark/sql/_types.py"
    run_test "pyspark/sql/context.py"
    run_test "pyspark/sql/dataframe.py"
    run_test "pyspark/sql/functions.py"
    run_test "pyspark/sql/tests.py"
}

function run_mllib_tests() {
    echo "Run mllib tests ..."
    run_test "pyspark/mllib/classification.py"
    run_test "pyspark/mllib/clustering.py"
    run_test "pyspark/mllib/evaluation.py"
    run_test "pyspark/mllib/feature.py"
    run_test "pyspark/mllib/fpm.py"
    run_test "pyspark/mllib/linalg.py"
    run_test "pyspark/mllib/rand.py"
    run_test "pyspark/mllib/recommendation.py"
    run_test "pyspark/mllib/regression.py"
    run_test "pyspark/mllib/stat/_statistics.py"
    run_test "pyspark/mllib/tree.py"
    run_test "pyspark/mllib/util.py"
    run_test "pyspark/mllib/tests.py"
}

function run_ml_tests() {
    echo "Run ml tests ..."
    run_test "pyspark/ml/feature.py"
    run_test "pyspark/ml/classification.py"
    run_test "pyspark/ml/tests.py"
}

function run_streaming_tests() {
    echo "Run streaming tests ..."

    KAFKA_ASSEMBLY_DIR="$FWDIR"/external/kafka-assembly
    JAR_PATH="${KAFKA_ASSEMBLY_DIR}/target/scala-${SPARK_SCALA_VERSION}"
    for f in "${JAR_PATH}"/spark-streaming-kafka-assembly-*.jar; do
      if [[ ! -e "$f" ]]; then
        echo "Failed to find Spark Streaming Kafka assembly jar in $KAFKA_ASSEMBLY_DIR" 1>&2
        echo "You need to build Spark with " \
             "'build/sbt assembly/assembly streaming-kafka-assembly/assembly' or" \
             "'build/mvn package' before running this program" 1>&2
        exit 1
      fi
      KAFKA_ASSEMBLY_JAR="$f"
    done

    export PYSPARK_SUBMIT_ARGS="--jars ${KAFKA_ASSEMBLY_JAR} pyspark-shell"
    run_test "pyspark/streaming/util.py"
    run_test "pyspark/streaming/tests.py"
}

echo "Running PySpark tests. Output is in python/$LOG_FILE."

export PYSPARK_PYTHON="python"

# Try to test with Python 2.6, since that's the minimum version that we support:
if [ $(which python2.6) ]; then
    export PYSPARK_PYTHON="python2.6"
fi

echo "Testing with Python version:"
$PYSPARK_PYTHON --version

run_core_tests
run_sql_tests
run_mllib_tests
run_ml_tests
run_streaming_tests

# Try to test with Python 3
if [ $(which python3.4) ]; then
    export PYSPARK_PYTHON="python3.4"
    echo "Testing with Python3.4 version:"
    $PYSPARK_PYTHON --version

    run_core_tests
    run_sql_tests
    run_mllib_tests
    run_ml_tests
    run_streaming_tests
fi

# Try to test with PyPy
if [ $(which pypy) ]; then
    export PYSPARK_PYTHON="pypy"
    echo "Testing with PyPy version:"
    $PYSPARK_PYTHON --version

    run_core_tests
    run_sql_tests
    run_streaming_tests
fi

if [[ $FAILED == 0 ]]; then
    now=$(date +"%s")
    echo -e "\033[32mTests passed \033[0min $(($now - $START)) seconds"
fi

# TODO: in the long-run, it would be nice to use a test runner like `nose`.
# The doctest fixtures are the current barrier to doing this.