Skip to content
Snippets Groups Projects
  • Josh Rosen's avatar
    82066a16
    [SPARK-13948] MiMa check should catch if the visibility changes to private · 82066a16
    Josh Rosen authored
    MiMa excludes are currently generated using both the current Spark version's classes and Spark 1.2.0's classes, but this doesn't make sense: we should only be ignoring classes which were `private` in the previous Spark version, not classes which became private in the current version.
    
    This patch updates `dev/mima` to only generate excludes with respect to the previous artifacts that MiMa checks against. It also updates `MimaBuild` so that `excludeClass` only applies directly to the class being excluded and not to its companion object (since a class and its companion object can have different accessibility).
    
    Author: Josh Rosen <joshrosen@databricks.com>
    
    Closes #11774 from JoshRosen/SPARK-13948.
    82066a16
    History
    [SPARK-13948] MiMa check should catch if the visibility changes to private
    Josh Rosen authored
    MiMa excludes are currently generated using both the current Spark version's classes and Spark 1.2.0's classes, but this doesn't make sense: we should only be ignoring classes which were `private` in the previous Spark version, not classes which became private in the current version.
    
    This patch updates `dev/mima` to only generate excludes with respect to the previous artifacts that MiMa checks against. It also updates `MimaBuild` so that `excludeClass` only applies directly to the class being excluded and not to its companion object (since a class and its companion object can have different accessibility).
    
    Author: Josh Rosen <joshrosen@databricks.com>
    
    Closes #11774 from JoshRosen/SPARK-13948.