Skip to content
  • Sean Owen's avatar
    18408528
    [SPARK-13823][CORE][STREAMING][SQL] Always specify Charset in String <->... · 18408528
    Sean Owen authored
    [SPARK-13823][CORE][STREAMING][SQL] Always specify Charset in String <-> byte[] conversions (and remaining Coverity items)
    
    ## What changes were proposed in this pull request?
    
    - Fixes calls to `new String(byte[])` or `String.getBytes()` that rely on platform default encoding, to use UTF-8
    - Same for `InputStreamReader` and `OutputStreamWriter` constructors
    - Standardizes on UTF-8 everywhere
    - Standardizes specifying the encoding with `StandardCharsets.UTF-8`, not the Guava constant or "UTF-8" (which means handling `UnuspportedEncodingException`)
    - (also addresses the other remaining Coverity scan issues, which are pretty trivial; these are separated into commit https://github.com/srowen/spark/commit/1deecd8d9ca986d8adb1a42d315890ce5349d29c )
    
    ## How was this patch tested?
    
    Jenkins tests
    
    Author: Sean Owen <sowen@cloudera.com>
    
    Closes #11657 from srowen/SPARK-13823.
    18408528
    [SPARK-13823][CORE][STREAMING][SQL] Always specify Charset in String <->...
    Sean Owen authored
    [SPARK-13823][CORE][STREAMING][SQL] Always specify Charset in String <-> byte[] conversions (and remaining Coverity items)
    
    ## What changes were proposed in this pull request?
    
    - Fixes calls to `new String(byte[])` or `String.getBytes()` that rely on platform default encoding, to use UTF-8
    - Same for `InputStreamReader` and `OutputStreamWriter` constructors
    - Standardizes on UTF-8 everywhere
    - Standardizes specifying the encoding with `StandardCharsets.UTF-8`, not the Guava constant or "UTF-8" (which means handling `UnuspportedEncodingException`)
    - (also addresses the other remaining Coverity scan issues, which are pretty trivial; these are separated into commit https://github.com/srowen/spark/commit/1deecd8d9ca986d8adb1a42d315890ce5349d29c )
    
    ## How was this patch tested?
    
    Jenkins tests
    
    Author: Sean Owen <sowen@cloudera.com>
    
    Closes #11657 from srowen/SPARK-13823.
Loading