Skip to content
Snippets Groups Projects
  • Xianyang Liu's avatar
    b0ae8712
    [SPARK-18420][BUILD] Fix the errors caused by lint check in Java · b0ae8712
    Xianyang Liu authored
    
    Small fix, fix the errors caused by lint check in Java
    
    - Clear unused objects and `UnusedImports`.
    - Add comments around the method `finalize` of `NioBufferedFileInputStream`to turn off checkstyle.
    - Cut the line which is longer than 100 characters into two lines.
    
    Travis CI.
    ```
    $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
    $ dev/lint-java
    ```
    Before:
    ```
    Checkstyle checks failed at following occurrences:
    [ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8] (imports) UnusedImports: Unused import - org.apache.commons.crypto.cipher.CryptoCipherFactory.
    [ERROR] src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5] (modifier) RedundantModifier: Redundant 'public' modifier.
    [ERROR] src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java:[133] (coding) NoFinalizer: Avoid using finalizer method.
    [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71] (sizes) LineLength: Line is longer than 100 characters (found 113).
    [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112] (sizes) LineLength: Line is longer than 100 characters (found 110).
    [ERROR] src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[31,17] (modifier) ModifierOrder: 'static' modifier out of order with the JLS suggestions.
    [ERROR]src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64] (sizes) LineLength: Line is longer than 100 characters (found 103).
    [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8] (imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
    [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51] (regexp) RegexpSingleline: No trailing whitespace allowed.
    ```
    
    After:
    ```
    $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
    $ dev/lint-java
    Using `mvn` from path: /home/travis/build/ConeyLiu/spark/build/apache-maven-3.3.9/bin/mvn
    Checkstyle checks passed.
    ```
    
    Author: Xianyang Liu <xyliu0530@icloud.com>
    
    Closes #15865 from ConeyLiu/master.
    
    (cherry picked from commit 7569cf6c)
    Signed-off-by: default avatarSean Owen <sowen@cloudera.com>
    [SPARK-18420][BUILD] Fix the errors caused by lint check in Java
    Xianyang Liu authored
    
    Small fix, fix the errors caused by lint check in Java
    
    - Clear unused objects and `UnusedImports`.
    - Add comments around the method `finalize` of `NioBufferedFileInputStream`to turn off checkstyle.
    - Cut the line which is longer than 100 characters into two lines.
    
    Travis CI.
    ```
    $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
    $ dev/lint-java
    ```
    Before:
    ```
    Checkstyle checks failed at following occurrences:
    [ERROR] src/main/java/org/apache/spark/network/util/TransportConf.java:[21,8] (imports) UnusedImports: Unused import - org.apache.commons.crypto.cipher.CryptoCipherFactory.
    [ERROR] src/test/java/org/apache/spark/network/sasl/SparkSaslSuite.java:[516,5] (modifier) RedundantModifier: Redundant 'public' modifier.
    [ERROR] src/main/java/org/apache/spark/io/NioBufferedFileInputStream.java:[133] (coding) NoFinalizer: Avoid using finalizer method.
    [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeMapData.java:[71] (sizes) LineLength: Line is longer than 100 characters (found 113).
    [ERROR] src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeArrayData.java:[112] (sizes) LineLength: Line is longer than 100 characters (found 110).
    [ERROR] src/test/java/org/apache/spark/sql/catalyst/expressions/HiveHasherSuite.java:[31,17] (modifier) ModifierOrder: 'static' modifier out of order with the JLS suggestions.
    [ERROR]src/main/java/org/apache/spark/examples/ml/JavaLogisticRegressionWithElasticNetExample.java:[64] (sizes) LineLength: Line is longer than 100 characters (found 103).
    [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[22,8] (imports) UnusedImports: Unused import - org.apache.spark.ml.linalg.Vectors.
    [ERROR] src/main/java/org/apache/spark/examples/ml/JavaInteractionExample.java:[51] (regexp) RegexpSingleline: No trailing whitespace allowed.
    ```
    
    After:
    ```
    $ build/mvn -T 4 -q -DskipTests -Pyarn -Phadoop-2.3 -Pkinesis-asl -Phive -Phive-thriftserver install
    $ dev/lint-java
    Using `mvn` from path: /home/travis/build/ConeyLiu/spark/build/apache-maven-3.3.9/bin/mvn
    Checkstyle checks passed.
    ```
    
    Author: Xianyang Liu <xyliu0530@icloud.com>
    
    Closes #15865 from ConeyLiu/master.
    
    (cherry picked from commit 7569cf6c)
    Signed-off-by: default avatarSean Owen <sowen@cloudera.com>