Skip to content
Snippets Groups Projects
  • George Dittmar's avatar
    3f7de7db
    [SPARK-7422] [MLLIB] Add argmax to Vector, SparseVector · 3f7de7db
    George Dittmar authored
    Modifying Vector, DenseVector, and SparseVector to implement argmax functionality. This work is to set the stage for changes to be done in Spark-7423.
    
    Author: George Dittmar <georgedittmar@gmail.com>
    Author: George <dittmar@Georges-MacBook-Pro.local>
    Author: dittmarg <george.dittmar@webtrends.com>
    Author: Xiangrui Meng <meng@databricks.com>
    
    Closes #6112 from GeorgeDittmar/SPARK-7422 and squashes the following commits:
    
    3e0a939 [George Dittmar] Merge pull request #1 from mengxr/SPARK-7422
    127dec5 [Xiangrui Meng] update argmax impl
    2ea6a55 [George Dittmar] Added MimaExcludes for Vectors.argmax
    98058f4 [George Dittmar] Merge branch 'master' of github.com:apache/spark into SPARK-7422
    5fd9380 [George Dittmar] fixing style check error
    42341fb [George Dittmar] refactoring arg max check to better handle zero values
    b22af46 [George Dittmar] Fixing spaces between commas in unit test
    f2eba2f [George Dittmar] Cleaning up unit tests to be fewer lines
    aa330e3 [George Dittmar] Fixing some last if else spacing issues
    ac53c55 [George Dittmar] changing dense vector argmax unit test to be one line call vs 2
    d5b5423 [George Dittmar] Fixing code style and updating if logic on when to check for zero values
    ee1a85a [George Dittmar] Cleaning up unit tests a bit and modifying a few cases
    3ee8711 [George Dittmar] Fixing corner case issue with zeros in the active values of the sparse vector. Updated unit tests
    b1f059f [George Dittmar] Added comment before we start arg max calculation. Updated unit tests to cover corner cases
    f21dcce [George Dittmar] commit
    af17981 [dittmarg] Initial work fixing bug that was made clear in pr
    eeda560 [George] Fixing SparseVector argmax function to ignore zero values while doing the calculation.
    4526acc [George] Merge branch 'master' of github.com:apache/spark into SPARK-7422
    df9538a [George] Added argmax to sparse vector and added unit test
    3cffed4 [George] Adding unit tests for argmax functions for Dense and Sparse vectors
    04677af [George] initial work on adding argmax to Vector and SparseVector
    3f7de7db
    History
    [SPARK-7422] [MLLIB] Add argmax to Vector, SparseVector
    George Dittmar authored
    Modifying Vector, DenseVector, and SparseVector to implement argmax functionality. This work is to set the stage for changes to be done in Spark-7423.
    
    Author: George Dittmar <georgedittmar@gmail.com>
    Author: George <dittmar@Georges-MacBook-Pro.local>
    Author: dittmarg <george.dittmar@webtrends.com>
    Author: Xiangrui Meng <meng@databricks.com>
    
    Closes #6112 from GeorgeDittmar/SPARK-7422 and squashes the following commits:
    
    3e0a939 [George Dittmar] Merge pull request #1 from mengxr/SPARK-7422
    127dec5 [Xiangrui Meng] update argmax impl
    2ea6a55 [George Dittmar] Added MimaExcludes for Vectors.argmax
    98058f4 [George Dittmar] Merge branch 'master' of github.com:apache/spark into SPARK-7422
    5fd9380 [George Dittmar] fixing style check error
    42341fb [George Dittmar] refactoring arg max check to better handle zero values
    b22af46 [George Dittmar] Fixing spaces between commas in unit test
    f2eba2f [George Dittmar] Cleaning up unit tests to be fewer lines
    aa330e3 [George Dittmar] Fixing some last if else spacing issues
    ac53c55 [George Dittmar] changing dense vector argmax unit test to be one line call vs 2
    d5b5423 [George Dittmar] Fixing code style and updating if logic on when to check for zero values
    ee1a85a [George Dittmar] Cleaning up unit tests a bit and modifying a few cases
    3ee8711 [George Dittmar] Fixing corner case issue with zeros in the active values of the sparse vector. Updated unit tests
    b1f059f [George Dittmar] Added comment before we start arg max calculation. Updated unit tests to cover corner cases
    f21dcce [George Dittmar] commit
    af17981 [dittmarg] Initial work fixing bug that was made clear in pr
    eeda560 [George] Fixing SparseVector argmax function to ignore zero values while doing the calculation.
    4526acc [George] Merge branch 'master' of github.com:apache/spark into SPARK-7422
    df9538a [George] Added argmax to sparse vector and added unit test
    3cffed4 [George] Adding unit tests for argmax functions for Dense and Sparse vectors
    04677af [George] initial work on adding argmax to Vector and SparseVector