Skip to content
Snippets Groups Projects
  • Holden Karau's avatar
    191ee474
    [SPARK-7511] [MLLIB] pyspark ml seed param should be random by default or 42... · 191ee474
    Holden Karau authored
    [SPARK-7511] [MLLIB] pyspark ml seed param should be random by default or 42 is quite funny but not very random
    
    Author: Holden Karau <holden@pigscanfly.ca>
    
    Closes #6139 from holdenk/SPARK-7511-pyspark-ml-seed-param-should-be-random-by-default-or-42-is-quite-funny-but-not-very-random and squashes the following commits:
    
    591f8e5 [Holden Karau] specify old seed for doc tests
    2470004 [Holden Karau] Fix a bunch of seeds with default values to have None as the default which will then result in using the hash of the class name
    cbad96d [Holden Karau] Add the setParams function that is used in the real code
    423b8d7 [Holden Karau] Switch the test code to behave slightly more like production code. also don't check the param map value only check for key existence
    140d25d [Holden Karau] remove extra space
    926165a [Holden Karau] Add some missing newlines for pep8 style
    8616751 [Holden Karau] merge in master
    58532e6 [Holden Karau] its the __name__ method, also treat None values as not set
    56ef24a [Holden Karau] fix test and regenerate base
    afdaa5c [Holden Karau] make sure different classes have different results
    68eb528 [Holden Karau] switch default seed to hash of type of self
    89c4611 [Holden Karau] Merge branch 'master' into SPARK-7511-pyspark-ml-seed-param-should-be-random-by-default-or-42-is-quite-funny-but-not-very-random
    31cd96f [Holden Karau] specify the seed to randomforestregressor test
    e1b947f [Holden Karau] Style fixes
    ce90ec8 [Holden Karau] merge in master
    bcdf3c9 [Holden Karau] update docstring seeds to none and some other default seeds from 42
    65eba21 [Holden Karau] pep8 fixes
    0e3797e [Holden Karau] Make seed default to random in more places
    213a543 [Holden Karau] Simplify the generated code to only include set default if there is a default rather than having None is note None in the generated code
    1ff17c2 [Holden Karau] Make the seed random for HasSeed in python
    191ee474
    History
    [SPARK-7511] [MLLIB] pyspark ml seed param should be random by default or 42...
    Holden Karau authored
    [SPARK-7511] [MLLIB] pyspark ml seed param should be random by default or 42 is quite funny but not very random
    
    Author: Holden Karau <holden@pigscanfly.ca>
    
    Closes #6139 from holdenk/SPARK-7511-pyspark-ml-seed-param-should-be-random-by-default-or-42-is-quite-funny-but-not-very-random and squashes the following commits:
    
    591f8e5 [Holden Karau] specify old seed for doc tests
    2470004 [Holden Karau] Fix a bunch of seeds with default values to have None as the default which will then result in using the hash of the class name
    cbad96d [Holden Karau] Add the setParams function that is used in the real code
    423b8d7 [Holden Karau] Switch the test code to behave slightly more like production code. also don't check the param map value only check for key existence
    140d25d [Holden Karau] remove extra space
    926165a [Holden Karau] Add some missing newlines for pep8 style
    8616751 [Holden Karau] merge in master
    58532e6 [Holden Karau] its the __name__ method, also treat None values as not set
    56ef24a [Holden Karau] fix test and regenerate base
    afdaa5c [Holden Karau] make sure different classes have different results
    68eb528 [Holden Karau] switch default seed to hash of type of self
    89c4611 [Holden Karau] Merge branch 'master' into SPARK-7511-pyspark-ml-seed-param-should-be-random-by-default-or-42-is-quite-funny-but-not-very-random
    31cd96f [Holden Karau] specify the seed to randomforestregressor test
    e1b947f [Holden Karau] Style fixes
    ce90ec8 [Holden Karau] merge in master
    bcdf3c9 [Holden Karau] update docstring seeds to none and some other default seeds from 42
    65eba21 [Holden Karau] pep8 fixes
    0e3797e [Holden Karau] Make seed default to random in more places
    213a543 [Holden Karau] Simplify the generated code to only include set default if there is a default rather than having None is note None in the generated code
    1ff17c2 [Holden Karau] Make the seed random for HasSeed in python