Skip to content
  • Kent Yao's avatar
    189f56f3
    [SPARK-23383][BUILD][MINOR] Make a distribution should exit with usage while... · 189f56f3
    Kent Yao authored
    [SPARK-23383][BUILD][MINOR] Make a distribution should exit with usage while detecting wrong options
    
    ## What changes were proposed in this pull request?
    ```shell
    ./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz  -Phadoop-2.7
    +++ dirname ./dev/make-distribution.sh
    ++ cd ./dev/..
    ++ pwd
    + SPARK_HOME=/Users/Kent/Documents/spark
    + DISTDIR=/Users/Kent/Documents/spark/dist
    + MAKE_TGZ=false
    + MAKE_PIP=false
    + MAKE_R=false
    + NAME=none
    + MVN=/Users/Kent/Documents/spark/build/mvn
    + ((  5  ))
    + case $1 in
    + NAME=ne-1.0.0-SNAPSHOT
    + shift
    + shift
    + ((  3  ))
    + case $1 in
    + break
    + '[' -z /Users/Kent/.jenv/candidates/java/current ']'
    + '[' -z /Users/Kent/.jenv/candidates/java/current ']'
    ++ command -v git
    + '[' /usr/local/bin/git ']'
    ++ git rev-parse --short HEAD
    + GITREV=98ea6a7
    + '[' '!' -z 98ea6a7 ']'
    + GITREVSTRING=' (git revision 98ea6a7)'
    + unset GITREV
    ++ command -v /Users/Kent/Documents/spark/build/mvn
    + '[' '!' /Users/Kent/Documents/spark/build/mvn ']'
    ++ /Users/Kent/Documents/spark/build/mvn help:evaluate -Dexpression=project.version xyz --tgz -Phadoop-2.7
    ++ grep -v INFO
    ++ tail -n 1
    + VERSION=' -X,--debug                             Produce execution debug output'
    ```
    It is better to declare the mistakes and exit with usage than `break`
    
    ## How was this patch tested?
    
    manually
    
    cc srowen
    
    Author: Kent Yao <yaooqinn@hotmail.com>
    
    Closes #20571 from yaooqinn/SPARK-23383.
    189f56f3
    [SPARK-23383][BUILD][MINOR] Make a distribution should exit with usage while...
    Kent Yao authored
    [SPARK-23383][BUILD][MINOR] Make a distribution should exit with usage while detecting wrong options
    
    ## What changes were proposed in this pull request?
    ```shell
    ./dev/make-distribution.sh --name ne-1.0.0-SNAPSHOT xyz --tgz  -Phadoop-2.7
    +++ dirname ./dev/make-distribution.sh
    ++ cd ./dev/..
    ++ pwd
    + SPARK_HOME=/Users/Kent/Documents/spark
    + DISTDIR=/Users/Kent/Documents/spark/dist
    + MAKE_TGZ=false
    + MAKE_PIP=false
    + MAKE_R=false
    + NAME=none
    + MVN=/Users/Kent/Documents/spark/build/mvn
    + ((  5  ))
    + case $1 in
    + NAME=ne-1.0.0-SNAPSHOT
    + shift
    + shift
    + ((  3  ))
    + case $1 in
    + break
    + '[' -z /Users/Kent/.jenv/candidates/java/current ']'
    + '[' -z /Users/Kent/.jenv/candidates/java/current ']'
    ++ command -v git
    + '[' /usr/local/bin/git ']'
    ++ git rev-parse --short HEAD
    + GITREV=98ea6a7
    + '[' '!' -z 98ea6a7 ']'
    + GITREVSTRING=' (git revision 98ea6a7)'
    + unset GITREV
    ++ command -v /Users/Kent/Documents/spark/build/mvn
    + '[' '!' /Users/Kent/Documents/spark/build/mvn ']'
    ++ /Users/Kent/Documents/spark/build/mvn help:evaluate -Dexpression=project.version xyz --tgz -Phadoop-2.7
    ++ grep -v INFO
    ++ tail -n 1
    + VERSION=' -X,--debug                             Produce execution debug output'
    ```
    It is better to declare the mistakes and exit with usage than `break`
    
    ## How was this patch tested?
    
    manually
    
    cc srowen
    
    Author: Kent Yao <yaooqinn@hotmail.com>
    
    Closes #20571 from yaooqinn/SPARK-23383.
Loading