Skip to content
Snippets Groups Projects
  • sethah's avatar
    129f2f45
    [SPARK-14104][PYSPARK][ML] All Python param setters should use the `_set` method · 129f2f45
    sethah authored
    ## What changes were proposed in this pull request?
    
    Param setters in python previously accessed the _paramMap directly to update values. The `_set` method now implements type checking, so it should be used to update all parameters. This PR eliminates all direct accesses to `_paramMap` besides the one in the `_set` method to ensure type checking happens.
    
    Additional changes:
    * [SPARK-13068](https://github.com/apache/spark/pull/11663) missed adding type converters in evaluation.py so those are done here
    * An incorrect `toBoolean` type converter was used for StringIndexer `handleInvalid` param in previous PR. This is fixed here.
    
    ## How was this patch tested?
    
    Existing unit tests verify that parameters are still set properly. No new functionality is actually added in this PR.
    
    Author: sethah <seth.hendrickson16@gmail.com>
    
    Closes #11939 from sethah/SPARK-14104.
    129f2f45
    History
    [SPARK-14104][PYSPARK][ML] All Python param setters should use the `_set` method
    sethah authored
    ## What changes were proposed in this pull request?
    
    Param setters in python previously accessed the _paramMap directly to update values. The `_set` method now implements type checking, so it should be used to update all parameters. This PR eliminates all direct accesses to `_paramMap` besides the one in the `_set` method to ensure type checking happens.
    
    Additional changes:
    * [SPARK-13068](https://github.com/apache/spark/pull/11663) missed adding type converters in evaluation.py so those are done here
    * An incorrect `toBoolean` type converter was used for StringIndexer `handleInvalid` param in previous PR. This is fixed here.
    
    ## How was this patch tested?
    
    Existing unit tests verify that parameters are still set properly. No new functionality is actually added in this PR.
    
    Author: sethah <seth.hendrickson16@gmail.com>
    
    Closes #11939 from sethah/SPARK-14104.