- Jun 01, 2017
-
-
AmanYang authored
Missed a break statement in case SET_QUEUE, which caused an error when parsing SET_QUEUE;
-
- Dec 01, 2016
-
-
Geddings Barrineau authored
* Fixed IP_TOS match problem. In MatchUtils.java where the IP_TOS match string is converted into ECN and DSCP fields, incorrect values were passed into each fields constructor. To fix the problem, the ECN and DSCP bits had to be isolated and then passed into each constructor. * Fixed a bug that had to do with the order of bitwise operations when dealing with IP_TOS matches. By adding parenthesis, we ensure that the 'and' is done before the 'shift'. * Fixed bug that would cause a set_dst_port action to result in a set_src_port action instead. Simple copy paste error.
-
- Jul 09, 2016
-
-
Ryan Izard authored
-
- Jun 30, 2016
-
-
Ryan Izard authored
convert integer DPIDs specified to the SEP to DatapathId to prevent duplicate DPID flow sets listed just because the DPID was entered in a different format. hexstring is what will be used
-
- Jun 20, 2016
-
-
Ryan Izard authored
Introduce ParseUtils as a cleaner way to parse hex or decimal strings to their primitive types. This is done instead of e.g. Integer.decode() in order to eliminiate the need to instantiate a new object wrapped around the primitive type if we're just going to use the primivitive type in the first place. Cleaned up all *Utils classes to use the new ParseUtils fuctions, which reduced a lot of duplicate code.
-
Ryan Izard authored
Update MatchUtils, ActionUtils, and GroupUtils to support converting OFGroup and OFPort types to/from strings more easily. This includes human-readable strings for special values, such as OFPort.CONTROLLER, etc., and OFGroup.ALL, etc.
-
- May 16, 2016
-
-
Ryan Izard authored
This is a huge commit. Lots of (good) stuff has been added and updated. First and foremost, OpenFlow 1.5 is now supported (yay) via a major update to OpenFlowJ-Loxi. This update necessitated the update of the Static Flow Pusher module and MatchUtils, ActionUtils, and InstructionUtils to support the newly-added features. This prompted me to explore the SFP to see if there was anything that could be improved. First thing that came to mind was adding support to push OpenFlow groups in addition to flows, thus group support has been added to the SFP via JSON, which is the format that should have been used in the first place. Action lists will be updated in the near future to be JSON instead of one massive ',', '=', and '->' delimited string. Thus, the Static Flow Pusher has been renamed the StaticEntryPusher, since it now encompasses groups. While groups were being added to the SFP (ahem...SEP), a number of optimizations were made to the SEP code, greatly reducing its complexity (IMHO). The support for OpenFlow meters can now be added rather trivially in the future, if desired. Last thing to note about the SEP is the work-in-progress addition of a 'schema' API to allow northbound applications to get information about SEP syntax. This is not complete yet, but the skeleton code is in place. Next thing in this pull request is miscellaneous changes throughout the controller, primarily in (de)serializers and REST APIs to support OpenFlow 1.5. Next item of business is the removal of the DebugEventService. This is an artifact of days past and need not clutter the controller anymore. Same goes for the TestModule; now that we have better tutorials and documentation on the wiki, an example isn't necessary. And, last but not least, some old libraries that weren't being used have now been removed.
-
- Apr 29, 2016
-
-
Ryan Izard authored
Update MatchUtils and ActionUtils to fully support parsing 32-bit signed and unsigned port numbers in hex and decimal from strings. Also improved and added more keywords for ingress and output ports to support local, table, normal, controller, in_port, all, and flood without care for the openflow version.
-
- Jan 21, 2016
-
-
paaguti-work authored
-
- Dec 16, 2015
-
-
Ryan Izard authored
Fix bug in ActionUtils. OF1.0 transport ports were being parsed as shorts. For ports above 32767, this is bad.
-
- Oct 06, 2015
-
-
Ryan Izard authored
-
- Apr 27, 2015
-
-
Ryan Izard authored
Fixed action serializer for actions that do not have values e.g. strip_vlan and such. Added in a 'n/a' value for the JSON key's value. Perhaps we should rethink how a list of actions is serialized to avoid the 'n/a' all together.
-
- Mar 09, 2015
-
-
Ryan Izard authored
Let's try this again. Fixed the two SFP bugs (Maxence's bug and another that prevented adding drop flows with null or empty-string actions). Also, replaced netty with a newer version in preparation for SSL support.
-
Ryan Izard authored
Revert "Fixed a couple bugs in SFP. (1) Always check the switch we're pushing a new flow to to see if an old flow needs to be removed from another switch (Maxence's bug). (2) Check for empty string in action lists and only print/add actions if they are specified. This allows an empty string or null to mean 'drop.'" This reverts commit e2458ef3.
-
Ryan Izard authored
Fixed a couple bugs in SFP. (1) Always check the switch we're pushing a new flow to to see if an old flow needs to be removed from another switch (Maxence's bug). (2) Check for empty string in action lists and only print/add actions if they are specified. This allows an empty string or null to mean 'drop.'
-
- Feb 04, 2015
-
-
Ryan Izard authored
-
- Dec 30, 2014
-
-
Ryan Izard authored
Just kidding. Went ahead and added a general try-catch in for actions and matches. In the next minor release, these messages will be returned as errors via the REST API so that partial flows cannot be inserted (based on the correct portions of the JSON-defined flow) and so that the log will not need to be inspected to find the root cause.
-
- Dec 22, 2014
-
-
sanjivininaikar authored
-
- Dec 17, 2014
-
-
Ryan Izard authored
Removed all deprecated FlowReconcileManager stuff from unit tests, which is just now showing up as a warning... Also clarified debug message in ActionUtils for actions that do not take the form 'key=value' e.g. 'pop_vlan'. It was phrased as if the action was bad, but it's okay for some that do not take a value.
-
- Dec 16, 2014
-
-
sanjivininaikar authored
IPv6 support updated
-
- Dec 15, 2014
-
-
sanjivininaikar authored
Support for IPv6
-
Ryan Izard authored
Tweaked SFP syntax (changed my mind about dl and nw as opposed to eth and ipv4). Added acceptance of hex and decimal input for values. Added previously unimplemented matches/actions in loxi to the SFP. Removed all the FlowReconcileManager stuff from DeviceManagerImpl.
-
- Dec 12, 2014
-
-
Ryan Izard authored
Fixed SFP REST API. Forgot to add new flow's DPID to entry2dpid map, thus flow removal never triggered a flow-del message to the switch. Also, added a serializer for OFFlowMod and for OFFlowModMap. The latter is for the double-map of switch-dpid --> map of flow-name --> OFFlowMod object. The former has been separated, since it a JSON serializer for OFFlowMod might come in handy in the future. A present limitation is that the JSON serializer does not use the same syntax as is used to insert a flow-mod via the SFP REST API. This might be confusing for people if they get different output than what they put in. It's a lot less work to implement the serializer as-is though. The next step will be to match the SFP syntax on a per-field basis in the OFFlowModSerializer class.
-
- Nov 21, 2014
-
-
Ryan Izard authored
-
- Nov 05, 2014
-
-
Ryan Izard authored
-
- Aug 14, 2014
-
-
Ryan Izard authored
Fixed lots of compile errors in unit tests; mostly involved replacing longs with DatapathIds, byte[]s with MacAddresses and Ipv4Addresses, and shorts with OFPorts and VlanVids; some refactoring of flow mod contruction was also done to align with loxi's builders. The static flow puser now supports IP TOS for OF1.0 and for OF1.1+ it supports match/rewrite to either ECN or DSCP bits.
-
- Aug 12, 2014
-
-
Ryan Izard authored
Static Flow Pusher supports all OF1.3 matches and most OF1.3 actions (with the exception of masks). LoadBalancer corrected; OFFlowAdd used instead of OFFlowModify and OFPort.ZERO correct to OFPort.ANY. ActionUtils, MatchUtils, and InstructionUtils added to support static flow pusher. Strings defining flow fields *standardized* for Floodlight in the new utils classes. This means the REST API for the SFP will expect a sligthly different syntax than the current REST API (for master and 0.90). We can change the field names easily though in the utils files. These names are also referenced for the keys the SFP uses to store flow match fields and actions, just to be consistent.
-
- Aug 10, 2014
-
-
Ryan Izard authored
Fixed build.xml. Fixed/implemented workaround for remaining debug counter compile errors to allow compilation with ant. Static Flow Pusher now matches on all OF1.3 match fields; all OF1.3 actions/set-field are in progress now, but basic out-port action works.
-