Include the completion listener in the MockFloodlightProvider

Fixed typo and deprecatedAPI call in the new onMessageConsumed

Modified Forwarding and ForwardingBase to use setInstructions instead of setActions in OF 1.1 or later. New openflowj-2.0.0-SNAPSHOT.jar that duplicates the shortcut used for FlowMod setActions in version 1.3 to versions 1.1, 1.2 and 1.4

Fix OF1.4 table features properties byte-align to 8 bytes. This required a Loxi update. Also updated handshake handler to not use action but instead instructions w/apply-actions.

Added unit test for writing messages while in MASTER/SLAVE. Changed to a blacklist mechanism instead of a whitelist (to match how the spec describes invalid (write) SLAVE messages). Completed invalid SLAVE messages for each OF version.

Updated to properly handle IOFSwitch write()'s while in SLAVE role. TODO: make unit test for trapping invalid messages while in SLAVE. TODO: complete logic for handling valid SLAVE message types per OF version.

We can shutdown gracefully and not wait (as Netty3 did). If not waiting turns out to be a problem, we can wait again.

Fixed a blunder in OFSwitchManager and Controller to allow switches to connect if a server IP isn't explicitly given in floodlihgtdefault.properties. Still can't get sync's bootstrap test to pass. Feels like a race condition b/t update threads.

Fix bug in ActionUtils. OF1.0 transport ports were being parsed as shorts. For ports above 32767, this is bad.

Core ported to Netty 4 along with unit tests. Still need to do sync and some loxi-related compile errors in web.serializers.

OF-DPA init and learning switch functions created. Possible use is commented out in ForwardingBase.java for the time being.

The dl_type=ARP (or any other dl_type) is overwritten if dst-ip/src-ip are specified later on in the json object. I added condition that only overwrites the field if it hasn't been already specified. This case only applies for src-ip, and dst-ip.

Tidy up topology and get rid of some many redundant functions in ITopologyService. Also, fix a bug that prevents outgoing broadcast ports from being queried on single-switch islands.

Patch Forwarding's pushPacket and pushRoute. We do not want to push a packet if the command is delete or delete-strict.

Wow. Not sure how that passed. Should have run ant (outside eclipse) -- would have given the compile error.

Added ability to disable ARP flows in Forwarding. Many hardware switches cannot handle ARP flows. ARP flows on by default; turn off/on via 'flood-arp' in floodlightdefault.properties. Also, finished integrating new topology service/routing into Forwarding. This required a few more null checks to handle cases where packet-ins are received while the controller is starting/still discovering the topology/links.

Fixed (really this time) the last bug WRT link latencies. This actually wasn't even a latency bug, but it existed beforehand. We only dispatch an update when checking for link timeouts if the link's unicast time just expired and we still have a valid multicast time. Otherwise, we remove the link if both unicast and multicast times are expired. Originally, we were dispatching updates when multicast times were expiring and unicast times were still valid. Such a case results in the link being in the unicast state before and after the multicast expiration; thus, no link update should be dispatched.

Topology manager now purges any existing link in its data structures before it tries to add a new link (no-op if one exists). This needs to be done in order to update latencies. Also changed some log levels.

Hooray! Fixed (fingers crossed) the last couple bugs WRT LLDP vs BDDP timing. Link discovery reaches a steady state now and latency updates do not impact the type of link (unicast/multicast) being reported to the topology manager.

Fix potential divide by zero. Increased latency parameters to threshold=0.50, history=10. Maybe it's just because my control plane is over a VPN and over the public internet, but the link latencies are fluctuating a bit. TODO evaluate whether or not we should completely clear the average/history each time we accept a new latency value. This would lessen the number of latency updates.

Change logging. Update default history size to 10. Base update decision on previous link value, not current observed.