Fix fromString of MatchUtils OFVlanVidMatch issue

Fix fromString of MatchUtils OFVlanVidMatch issue

Fix for Firewall issue #590

The dl_type=ARP (or any other dl_type) is overwritten if dst-ip/src-ip are specified later on in the json object. I added condition that only overwrites the field if it hasn't been already specified. This case only applies for src-ip, and dst-ip.

Forwarding bug fix for edge-case simple topology

Single-switch islands list correct outgoing broadcast ports; tidy up topology service

Tidy up topology and get rid of some many redundant functions in ITopologyService. Also, fix a bug that prevents outgoing broadcast ports from being queried on single-switch islands.

Patch Forwarding's pushRoute and pushPacket

Patch Forwarding's pushPacket and pushRoute. We do not want to push a packet if the command is delete or delete-strict.

Revert hard and idle timeout to public

Wow. Not sure how that passed. Should have run ant (outside eclipse) -- would have given the compile error.

Finish new topology service integration by patching Forwarding + one new feature

Added ability to disable ARP flows in Forwarding. Many hardware switches cannot handle ARP flows. ARP flows on by default; turn off/on via 'flood-arp' in floodlightdefault.properties. Also, finished integrating new topology service/routing into Forwarding. This required a few more null checks to handle cases where packet-ins are received while the controller is starting/still discovering the topology/links.

More robust link latency tracking for stable topology updates

Fixed (really this time) the last bug WRT link latencies. This actually wasn't even a latency bug, but it existed beforehand. We only dispatch an update when checking for link timeouts if the link's unicast time just expired and we still have a valid multicast time. Otherwise, we remove the link if both unicast and multicast times are expired. Originally, we were dispatching updates when multicast times were expiring and unicast times were still valid. Such a case results in the link being in the unicast state before and after the multicast expiration; thus, no link update should be dispatched.

Topology manager now purges any existing link in its data structures before it tries to add a new link (no-op if one exists). This needs to be done in order to update latencies. Also changed some log levels.

Hooray! Fixed (fingers crossed) the last couple bugs WRT LLDP vs BDDP timing. Link discovery reaches a steady state now and latency updates do not impact the type of link (unicast/multicast) being reported to the topology manager.

Fix potential divide by zero. Increased latency parameters to threshold=0.50, history=10. Maybe it's just because my control plane is over a VPN and over the public internet, but the link latencies are fluctuating a bit. TODO evaluate whether or not we should completely clear the average/history each time we accept a new latency value. This would lessen the number of latency updates.

Change logging. Update default history size to 10. Base update decision on previous link value, not current observed.

Implemented a rolling link latency history for switch links. Each link will contain a single latency value. When a link update occurs, the latency computed from the LLDP packet is added to the exisiting link's LinkInfo. LinkInfo maintains a latency history for link L. The 1-to-1 mapping between Link and LinkInfo still exists. LinkInfo will provide a new latency based on the rolling window size and update threshold -- configurable through floodlightdefault.properties but default to 5 latency data points and 30%, respectively. As an example, the 0th latency value is used as the intial latency for a particular (new) link. Each LLDP update for this link will contain a latency. This latency is added to the LinkInfo from updates 0 - 3. Update 4 will make 5 historical latency data points. This will cause an average to be computed of these 5 data points. If the average is +/-30% of the latency recorded in the 0th latency, the link latency will be updated. For exach, successive latency recorded, the same average will be computed. If the new average is not +/-30% of the old recorded value, an update will not occcur. Every latency 'replacement/update' will cause a new topology to be computed in the topology manager. Keeping a rolling average takes into account current network conditions, but also helps to average out outliers and keeps topology updates to a minimum.

Integrated new topology code and updated unit tests to a passing state. I'd be more comfortable adding more unit tests to the topology. Also made some changes to the link discovery manager's latency subsystem. We start with a baseline latency based on the switch's features reply turnaround time. This should be relatively quick -- just like an echo. Next step for latency is to keep a rolling list of past latencies for more defined topology updates based on latency updates. We don't want to update latencies too frequently, since tiny changes (or outliers) shouldn't require a complete topology recomputation.

Allow Load Balancer to LB multiple connections from single source host

Patch load balancer to include source port in static flow pusher entry names. This will allow a single source host to have multiple connections load-balanced across multiple LB hosts.

Link latency estimation

We now take into account the one-way latency between each switch (src, dst) and the controller when determining data plane link latencies.

First round of support for primitive link latency detection. We do not presently account for the latency between the switches and the controller.

Fixed srcPort bug in compareTo()

TCP checksum error. New code, based on JSocket Wrench code.

Better to rely on the compareTo() method of DatapathId and OFPort.