We now take into account the one-way latency between each switch (src, dst) and the controller when determining data plane link latencies.

First round of support for primitive link latency detection. We do not presently account for the latency between the switches and the controller.

Forwarding unit tests updated to test for IPv6 forwarding. Updated IPv6 and Ethernet to print known packets correctly and account for forgetting to set the IpProtocol, respectively.

Added some IPv6 tests and added the IPv6 secondary index to the device manager's init function (ooops).

A new and improved device manager (woohoo). We support IPv6 now and have fixed some bugs. Other changes have been made to prefer 'empty/zero' objects instead of null, which made using the device manger less type safe and more error prone. Unit tests for IPv6 packets will come next, so IPv6 support should be considered experimental for this commit (although in theory it should be fine if IPv4 is).

Lots of goodies here. Apologies for the largish commit. Most files are just removing warnings that were introduced after updating JSON libraries a short time ago. IOFSwitch now can return specific list of tables supported. This is useful for the OFHandshakeHandler for one, which not inserts table miss flows up to the table ID indicated in floodlightdefault.properties, but only in the table IDs that actually exist. Up next, Forwarding has some preliminary, isolated support for IPv6. Still need to integrate support into the device service, which is more complex. Forwarding also supports routing through OF switches of multiple OFVersions. This was a very subtle bug that was fixed by modifying MatchUtils to create a Match clone to a specific OFVersion. This utility function is used to generate a Match compatible with the OpenFlow version of the switch. Believe it or not, Loxi actually allows you to insert a Match of OFVersion.OF_X into an OFFlowMod of OFVersion.OF_Y. The switch, of course, doesn't have a clue how to interpret it and either reports an error, or actually resets the OF channel, in the case of a couple hardware switches tested on. Good news is this is fixed now :-).

Patched the handshake so that on transition to master, we guarantee the order of flow table operations (e.g. clear, adding table-miss flows, and IOFSwitchListener module switchAdded/switchActivated listener operations). Barriers are used inbetween all such operations.

Tweaked configuration of table-miss flows so that you can specify the number of tables rather than the max table ID. Both of these have their pros and cons, but we'll go with specifying the max total for now, which allows a '0' to indicate 'no tables' rather than 'up to and including table 0'.

First go at implementing OpenFlow version bitmaps. Also, made it a lot easier to change your default OpenFlow versions via floodlightdefault.properties's net.floodlightcontroller.OFSwitchManager.supportedOpenFlowVersions variable. The variable searches any string for 1.0, 1.1, 1.2, 1.3, and 1.4 and saves those versions as possible OpenFlow versions to use during a handshake and used in our controller's version bitmap. We don't presently account for future versions that might be e.g. 1.10 (which 1.1 would match). We need to use regexs to make the string parsing more robust. What I also noticed in working on this commit was that there are no utilies for parsing OpenFlow versions from wire (at least that are exposed by Loxi). TODO Create an OFVersion.ofWireValue(int wireVal) function in Loxi that efficiently tries to locate an OpenFlow version from the wire value. Right now, there are getters for each defined version, but not a utility to go the other way. Also, it might be useful to include an OFVersion.ofString(String laypersonString) that takes e.g. '1.1' and tries to get the OFVersion enum value. Last thing: NEED TO FIX CONNECT, DISCONNECT, and RECONNECT BUG that only occurs when OVS connects to Floodlight after Floodlight has been running first. I think it has to do with how OVS starts up and ***might*** be an OVS issue and not a Floodlight issue. Furthermore, need to allow OVS to send a PORT_STATUS message before we query for the PORT_CONFIG in the handshake. It's okay, we'll just get the port info again when we query for it shortly. This causes us to disconnect OVS even though the handshake is okay.

Patched ARP class to use MacAddress, IPv4Address, and ArpOpcode, as it should. This makes it safer and avoids primitive data types.

messages

Fixed what was likely one of the dependency issues in the unit tests. There were two @Before annotations on functions in the handshake handler tests. setUp() depends on setUpFeaturesReply(); but if they are both @Before, there's no guarantee the first @Before (features reply) will be executed before the second @Before (setup). Removed @Before annotation from setUpFeaturesReply() and manually invoke that function from within setUp() so that the featuresReply class variable is set when it's needed in setUp().

Added ability to specify the tables to receive table-miss flows for OF1.3+ switches. What we did before was insert these table-miss flows in all tables, which for OVS is 254 flows and not only is a waste of resources if the tables aren't being used, but also serverly clutters the REST API and Web UI output when listing flows. By default, the first 4 tables will receive the forward-to-controller table-miss flow. The reason for 4 is to account for a small number of software tables present on many hardware switches. If the actual number of tables is less, the lesser value will be used. To modify these settings, there are two options: (1) change the default for all switches or (2) specify the max tables to insert the table-miss flow on a per-DPID basis. These options are exposed in the floodlightdefault.properties file. Toy, no-op examples are given setting the default to 4 and two switches to 4 (the internal default is 4, thus it's a no-op). The list of switches and max tables should be given as a list of JSON key:value objects to the net.floodlightcontroller.core.internal.OFSwitchManager.maxTableToReceiveTableMissFlowPerDpid config variable. The default can be specified as an integer to the net.floodlightcontroller.core.internal.OFSwitchManager.defaultMaxTableToReceiveTableMissFlow variable.

Support for OFTableFeatures messages. OpenFlowJ-Loxi bindings have been updated to support a variable pad (byte-aligned to 8 bytes) for each OFTableFeaturesProp list. Loxi has not been 'officially' updated yet though due to a lack of a C implementation. The handshake handler in Floodlight and the switch representations were also updated in order to support OFTableFeatures. By default, the features are requested for an OF1.3+ switch. They will be updated if they are reconfigured through a writeRequest() call IOFSwitch. To access table features, call getTableFeatures(TableId tableToGetFeaturesFor). They are exposed as a TableFeatures type, which more is more efficient than OFTableFeatures for frequent data accesses (especialy OFTableFeatureProp lists).

Added ability to switch OF roles per DPID or for all switches at once. This includes a REST interface and integration with the handshake and channel handlers in order to keep the switch in the correct state. An IOFConnectionListener also has the ability to listen for messages that are written now instead of read from the wire. This allows modules to write role requests, have the underlying handshake/channel substrate tap in and listen to the request, and automatically update the role of the switch when the response comes back.

Initial DHCP server code commit. This was a test of how easy is is to port v0.91- code to v1.0. I have not tested this module yet. TODO: Write unit tests for the dhcpserver module.

Reapplied the LinkDiscoveryManager's patch from earlier (issue #471). Updated Ethernet.java to use EthType instead of short for EthTypes. In conjunction, bitmasked the LSBs of the ethertype as it is casted from short to int. This preserves the MSB (sign) as a data bit --> unsigned integer.

Added a patch to support HP ProCurve switches and others that do not support the OFPT_BARRIER_REQUEST message. Updated SFP unit test to include the SEND_FLOW_REM flag in the test flows (forgot from last commit).

Added insertion of default table-miss flow for OF1.3 switches. Also added clearing of switch tables when switch connects. Both of these only occur if the controller is in the MASTER role for the switch. It if is placed in SLAVE, the switch flow tables will not be modified. Also had to update the unit tests with new expectations for IOFSwitchBackend fuction calls (which was a real pain).

Removed all deprecated FlowReconcileManager stuff from unit tests, which is just now showing up as a warning... Also clarified debug message in ActionUtils for actions that do not take the form 'key=value' e.g. 'pop_vlan'. It was phrased as if the action was bad, but it's okay for some that do not take a value.

Tweaked SFP syntax (changed my mind about dl and nw as opposed to eth and ipv4). Added acceptance of hex and decimal input for values. Added previously unimplemented matches/actions in loxi to the SFP. Removed all the FlowReconcileManager stuff from DeviceManagerImpl.

Added in NXMs for source and destination tunnel IPs, included in new Loxigen 0.9.0. Used Loxigen's OFFlowModFlags serializers for different OFVersions to fix compile error in StatsReplySerializer introduced upon Loxigen upgrade. Add new OF1.4 counters to DebugCounters to allow unit tests to compile (this is the first step in OF1.4 support =) ).

Updated all unit tests with the uncommenting of debugcounter stuff in the previous commit. For the most part, initialized the MockDebugCounterService and provided it to the MemoryStorageSource to allow counters in the AbstractStorageSourceService.

Removed all deprecated flowcache references and marked all flowcache classes as deprecated. Also TODOed the OFMessageDamper Forwarding module unit test. It will always fail until tthe OFMessageDamper is fixed to ignore the XIDs in OFMessages.

OF1.3 handshake unit tests updated. All unit tests can be run together and have zero errors but one failure. The failure is in Forwarding and is expected for the time being until OFMessageDamper/Loxigen is fixed to ignore XIDs in OFMessages. In the previous commit, the unit tests for the flowcache package were completely removed due to the effort required to fix them. I don't know if completely removing the flowcache package though is the best idea. Even if it's not tested and not proven scalable, people might benefit from being able to look at the code. Thus, I've left the package in, at least for the time being.