Many REST ingest schemes (e.g. Graylog "JSON path from HTTP") expect servers to return well-formed JSON objects.  Floodlight is sometimes returning values that lack root objects.

Was:
   [ <list-of-device-objects>]

Now:
   { 'devices' : <list-of-device-objects> }

Add default of FALSE to allowing all origins in cross-domain requests. Remove old CORS code that was commented out.

Update Web UI to default to /ui/index.html for any request to /ui/. Also add in a filter for allowing any origin.

Updated to Java 8, junit-4.12, easymock-3.4. Still having trouble having unit tests pass in Eclipse for DeviceManagerImplTest, but they work find in maven and ant. testPacketInBasic and testPacketInBasicIPv6 are the trouble makers (fail occasionally).

Update MatchUtils and ActionUtils to fully support parsing 32-bit signed and unsigned port numbers in hex and decimal from strings. Also improved and added more keywords for ingress and output ports to support local, table, normal, controller, in_port, all, and flood without care for the openflow version.

Handle link and port down events in Forwarding. Remove flows ingress and egress a failed port or link to eliminate stale entries. This is done in Forwarding instead of the Link Discovery Manager, since some user modules might not want their flows removed and wish for them to persist until the link comes back up.

Add link speed to statistics REST API, which might be useful to gauge how much of the available bandwidth is being used.

Fired when receive a ROLE_STATUS message, at Master to Slave transitions, switch become deactivated.

Author, and minimal changes.

Tests ok.

NullPointerException verifications.

ant tests passed.

Switch roles from floodlightdefault.properties.

Fault tolerance with primary-backup or distributed, without reconfiguration.
One time crashed the controller shall restart with all switches in slave mode.
This can be achieved from floodlight.properties file.

The second properties file, floodlighBackupNode.properties is for backup nodes, and swicthes shall be configures in slave mode.

Regards

Hello guys, I have changed the logic of simple.FT (Fault Tolerant) module.

The basic idea is, the FT module register on SyncManager to receive RPC events
(connect and disconect nodes).

In connect events, the controller send its switch list to storage and
the other controllers can sync this info.
In disconnect events, the controller is informed about which controller crashed and
get switch list from storage and send a role request message to swicthes.

Regards.

and compare with initial cluster config defined in floodlightdefault.properties.

Issues: Do not treat the message ROLE_STATUS.
In case a cluster goes down and goes up, there is a problem, the Controller does not change its own role to role slave.

But works properly as Primary-Backup configuration.

Under development...

and compare with initial cluster config defined in floodlightdefault.properties.

Issues: do not treat the message ROLE_STATUS.
In case a cluster goes down and goes up, there is a problem, the Controller does not change its own role to role slave.

But works properly as Primary-Backup configuration.

Under development...

But from ant file there is some errors.

If I run this test lonely in Eclipse with JUnit, it is ok.
[junit] Running org.sdnplatform.sync.internal.store.RemoteStoreTest
[junit] Tests run: 8, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 13,244 sec

[junit] Running org.sdnplatform.sync.internal.SyncManagerTest
[junit] Tests run: 13, Failures: 8, Errors: 0, Skipped: 3, Time elapsed: 15,847 sec

TESTS RESULT:

worm@TAR:~/ForkFloodlight/floodlight$ ant tests
Buildfile: /home/worm/ForkFloodlight/floodlight/build.xml

init:

compile:
    [javac] Compiling 1 source file to /home/worm/ForkFloodlight/floodlight/target/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.7
    [javac] 1 warning

compile-test:

test:
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLRuleResourceTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,517 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLRuleTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLTest
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,29 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.APManagerTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.IPAddressUtilTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.core.internal.ControllerTest
    [junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,382 sec
    [junit] Running net.floodlightcontroller.core.internal.OFChannelHandlerVer10Test
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,148 sec
    [junit] Running net.floodlightcontroller.core.internal.OFChannelHandlerVer13Test
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,055 sec
    [junit] Running net.floodlightcontroller.core.internal.OFConnectionTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,078 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchBaseTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,055 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchHandshakeHandlerVer10Test
    [junit] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,276 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchHandshakeHandlerVer13Test
    [junit] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,214 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchManagerTest
    [junit] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,165 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,017 sec
    [junit] Running net.floodlightcontroller.core.internal.RoleManagerTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,037 sec
    [junit] Running net.floodlightcontroller.core.util.AppCookieTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.core.util.MessageDispatcherTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,158 sec
    [junit] Running net.floodlightcontroller.core.util.SingletonTaskTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,589 sec
    [junit] Running net.floodlightcontroller.debugcounter.DebugCounterImplTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.debugcounter.DebugCounterServiceTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,009 sec
    [junit] Running net.floodlightcontroller.debugcounter.OFConnectionCountersTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,078 sec
    [junit] Running net.floodlightcontroller.debugevent.DebugEventTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,014 sec
    [junit] Running net.floodlightcontroller.debugevent.EventTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.devicemanager.internal.DeviceManagerImplTest
    [junit] Tests run: 37, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,477 sec
    [junit] Running net.floodlightcontroller.devicemanager.internal.DeviceUniqueIndexTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.firewall.FirewallTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,073 sec
    [junit] Running net.floodlightcontroller.forwarding.ForwardingTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,075 sec
    [junit] Running net.floodlightcontroller.hub.HubTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,006 sec
    [junit] Running net.floodlightcontroller.learningswitch.LearningSwitchTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,016 sec
    [junit] Running net.floodlightcontroller.linkdiscovery.internal.LinkDiscoveryManagerTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,394 sec
    [junit] Running net.floodlightcontroller.loadbalancer.LoadBalancerTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,044 sec
    [junit] Running net.floodlightcontroller.notification.NotificationTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.packet.BSNTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.DHCPTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.packet.EthernetTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.packet.ICMPTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.IPv4Test
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.packet.IPv6Test
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.packet.LLDPOrganizationalTLVTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,012 sec
    [junit] Running net.floodlightcontroller.packet.LLDPTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.PacketTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.packet.SPUDTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.TCPTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.UDPTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.routing.RouteTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.staticflowentry.StaticFlowTests
    [junit] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0,008 sec
    [junit] TEST net.floodlightcontroller.staticflowentry.StaticFlowTests FAILED
    [junit] Running net.floodlightcontroller.storage.memory.tests.MemoryStorageTest
    [junit] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,053 sec
    [junit] Running net.floodlightcontroller.topology.TopologyInstanceTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,029 sec
    [junit] Running net.floodlightcontroller.topology.TopologyManagerTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.util.EnumBitmapsTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.util.OFMessageDamperTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,124 sec
    [junit] Running net.floodlightcontroller.util.TimedCacheTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,069 sec
    [junit] Running net.floodlightcontroller.virtualnetwork.VirtualNetworkFilterTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,072 sec
    [junit] Running org.sdnplatform.sync.VersionedTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running org.sdnplatform.sync.client.ClientTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,951 sec
    [junit] Running org.sdnplatform.sync.internal.BootstrapTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50,547 sec
    [junit] Running org.sdnplatform.sync.internal.SyncManagerTest
    [junit] Tests run: 13, Failures: 8, Errors: 0, Skipped: 3, Time elapsed: 15,847 sec
    [junit] TEST org.sdnplatform.sync.internal.SyncManagerTest FAILED
    [junit] Running org.sdnplatform.sync.internal.store.InMemoryStorageEngineTest
    [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,514 sec
    [junit] Running org.sdnplatform.sync.internal.store.JacksonStoreTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,057 sec
    [junit] Running org.sdnplatform.sync.internal.store.JavaDBStorageEngineTest
    [junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,578 sec
    [junit] Running org.sdnplatform.sync.internal.store.RemoteStoreTest
    [junit] Tests run: 8, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 13,244 sec
    [junit] TEST org.sdnplatform.sync.internal.store.RemoteStoreTest FAILED
    [junit] Running org.sdnplatform.sync.internal.version.ClockEntryTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running org.sdnplatform.sync.internal.version.VectorClockInconsistencyResolverTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running org.sdnplatform.sync.internal.version.VectorClockTest
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,013 sec
    [junit] Tests FAILED

BUILD FAILED
/home/worm/ForkFloodlight/floodlight/build.xml:223: Unit test(s) failed.  See reports!

SyncManager results:
13:08:12.696 ERROR [i.n.u.ResourceLeakDetector:main] LEAK: You are creating too many HashedWheelTimer instances.  HashedWheelTimer is a shared resource that must be reused across the JVM,so that only a few instances are created.

The value of CHALLENGE_RESPONSE_SECRET needs to be the value of "-alias" option from keytool, as follow:

keytool -genkey -alias AliasChallengeResponse -keystore key.jceks -keypass "PassWord" -storepass "PassWord" -storetype JCEKS

Main changes:

CHALLENGE_RESPONSE_SECRET = "AliasChallengeResponse"; -> hard coded.