Comma-delimited now. There will be an issue if a key is invalid, but this is a good start. If a key is invalid, we might output a double-comma where the key would have normally been inbetween.

Fixed a tough bug in MatchUtils. OFPorts are integers in OF1.3, but those who specify local, controller, etc. as 65534, etc. will not work with OF1.3. This is a temporary fix and should be fixed properly to allow the full range of ports.

Let's try this again. Fixed the two SFP bugs (Maxence's bug and another that prevented adding drop flows with null or empty-string actions). Also, replaced netty with a newer version in preparation for SSL support.

Revert "Fixed a couple bugs in SFP. (1) Always check the switch we're pushing a new flow to to see if an old flow needs to be removed from another switch (Maxence's bug). (2) Check for empty string in action lists and only print/add actions if they are specified. This allows an empty string or null to mean 'drop.'"

This reverts commit e2458ef3.

Fixed a couple bugs in SFP. (1) Always check the switch we're pushing a new flow to to see if an old flow needs to be removed from another switch (Maxence's bug). (2) Check for empty string in action lists and only print/add actions if they are specified. This allows an empty string or null to mean 'drop.'

SFP supports hard/idle timouts w/drawback of needlessly sending flow_del to switch (which gets silently discarded). This is a good first step but needs to be followed up with a solution to the redundant flow_del msg. Also, patched MatchSerializer to display masks if present and fixed a bug in OFInstructionListSerializer for metadata and goto_table instructions. Added masking support to all SFP match fields. OVS supports some masked fields that are not defined in the OF1.3 spec. Oddly enough, OVS returns a bad-match error message even though the flow gets inserted. I suppose that message is due to the OF protocol not supporting it. OVS should squelch it if it supports it though. In any case, Floodlight is equipped to support all present MatchFields as masked MatchFields in the future. To specify a mask to any field (beside MPLS BOS, which is a boolean), use a CIDR-style '/' after the value and before the mask. All values and masks support decimal or hexadecimal (with leading '0x'), with the exception of all values that are MacAddress or IPAddress types -- they only support hex-string or dotted-decimal, respectively. Lastly, an English typo has been fixed in IStaticFlowEntryPusherService.

Removed some more unnecessary comments. Don't know how hard_timeout and idle_timeout got reverted in the SFP...

Last-minute SFP additions to catch some exceptions. Still have more to go, but they can wait, since it'd be from user error.

IPv6 support updated

Support for IPv6

Fixed SFP REST API. Forgot to add new flow's DPID to entry2dpid map, thus flow removal never triggered a flow-del message to the switch. Also, added a serializer for OFFlowMod and for OFFlowModMap. The latter is for the double-map of switch-dpid --> map of flow-name --> OFFlowMod object. The former has been separated, since it a JSON serializer for OFFlowMod might come in handy in the future. A present limitation is that the JSON serializer does not use the same syntax as is used to insert a flow-mod via the SFP REST API. This might be confusing for people if they get different output than what they put in. It's a lot less work to implement the serializer as-is though. The next step will be to match the SFP syntax on a per-field basis in the OFFlowModSerializer class.

Updated all unit tests with the uncommenting of debugcounter stuff in the previous commit. For the most part, initialized the MockDebugCounterService and provided it to the MemoryStorageSource to allow counters in the AbstractStorageSourceService.

Fixed lots of compile errors in unit tests; mostly involved replacing longs with DatapathIds, byte[]s with MacAddresses and Ipv4Addresses, and shorts with OFPorts and VlanVids; some refactoring of flow mod contruction was also done to align with loxi's builders. The static flow puser now supports IP TOS for OF1.0 and for OF1.1+ it supports match/rewrite to either ECN or DSCP bits.

Static Flow Pusher supports all OF1.3 matches and most OF1.3 actions (with the exception of masks). LoadBalancer corrected; OFFlowAdd used instead of OFFlowModify and OFPort.ZERO correct to OFPort.ANY. ActionUtils, MatchUtils, and InstructionUtils added to support static flow pusher. Strings defining flow fields *standardized* for Floodlight in the new utils classes. This means the REST API for the SFP will expect a sligthly different syntax than the current REST API (for master and 0.90). We can change the field names easily though in the utils files. These names are also referenced for the keys the SFP uses to store flow match fields and actions, just to be consistent.

Fixed build.xml. Fixed/implemented workaround for remaining debug counter compile errors to allow compilation with ant. Static Flow Pusher now matches on all OF1.3 match fields; all OF1.3 actions/set-field are in progress now, but basic out-port action works.

VLAN matches added conditionally to Forwarding flows. Started moving sync code to the OFSwitchManager; not sure if SyncService needs to live there too.

Removed BSN-specific handshakes, some debug messages, tweaked static flow entry pusher, and hub to work with new OpenFlowJ-Loxi flow mod commands.

* fail makeCookie if the app id hasn't been registered
* do static initialization
* fail if duplicate app id registration

still not a perfect framework but better than before

* add methods to update/compare the ports of an IOFSwitch
* use ImmutablePorts
* OFPhysicalPorts -> ImmutablePort in most test

* make sure we do things in the right order (setting role, sending role reqs)
* fix getName() in HAListener's
* transition AddressSpaceManager before DeviceManager to Master
* flush counters from threads
* add trace logging and more counters

Still needs more work:
 * we don't generate updates if a stored switch has changed yet
 * we don't deal with (unlikely) change of port name <-> number

Necessary step for switch sync. We can't use
IFloodlightProvider.getSwitches() anymore. We now have a getSwitch()
method. There are also methods to get all dpids (getAllSwitchDpids())
and to get a map (getAllSwitchesMap()). These two return a snapshot.
TODO: need to check if they are used under the correct assumption in
existing code.

First stab at SwitchSyncRepresentation, which is the object I indent to
put in the SyncStore.

Also fixed an issue in Static Flow Pusher that would leave an orphaned flow if a static flow changed it's DPID.

FLOODLIGHT-30 - When deleting all entries put in by the static flow pusher for a specific switch or all switches   use a single delete based on matching the static flow pusher cookie instead of deleting each   flow individually.   Note: this means that flows mods are no longer hashed to have unique cookies.