and compare with initial cluster config defined in floodlightdefault.properties.

Issues: do not treat the message ROLE_STATUS.
In case a cluster goes down and goes up, there is a problem, the Controller does not change its own role to role slave.

But works properly as Primary-Backup configuration.

Under development...

But from ant file there is some errors.

If I run this test lonely in Eclipse with JUnit, it is ok.
[junit] Running org.sdnplatform.sync.internal.store.RemoteStoreTest
[junit] Tests run: 8, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 13,244 sec

[junit] Running org.sdnplatform.sync.internal.SyncManagerTest
[junit] Tests run: 13, Failures: 8, Errors: 0, Skipped: 3, Time elapsed: 15,847 sec

TESTS RESULT:

worm@TAR:~/ForkFloodlight/floodlight$ ant tests
Buildfile: /home/worm/ForkFloodlight/floodlight/build.xml

init:

compile:
    [javac] Compiling 1 source file to /home/worm/ForkFloodlight/floodlight/target/bin
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.7
    [javac] 1 warning

compile-test:

test:
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLRuleResourceTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,517 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLRuleTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.ACLTest
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,29 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.APManagerTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.accesscontrollist.IPAddressUtilTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.core.internal.ControllerTest
    [junit] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,382 sec
    [junit] Running net.floodlightcontroller.core.internal.OFChannelHandlerVer10Test
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,148 sec
    [junit] Running net.floodlightcontroller.core.internal.OFChannelHandlerVer13Test
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,055 sec
    [junit] Running net.floodlightcontroller.core.internal.OFConnectionTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,078 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchBaseTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,055 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchHandshakeHandlerVer10Test
    [junit] Tests run: 27, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,276 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchHandshakeHandlerVer13Test
    [junit] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,214 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchManagerTest
    [junit] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,165 sec
    [junit] Running net.floodlightcontroller.core.internal.OFSwitchTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,017 sec
    [junit] Running net.floodlightcontroller.core.internal.RoleManagerTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,037 sec
    [junit] Running net.floodlightcontroller.core.util.AppCookieTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.core.util.MessageDispatcherTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,158 sec
    [junit] Running net.floodlightcontroller.core.util.SingletonTaskTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,589 sec
    [junit] Running net.floodlightcontroller.debugcounter.DebugCounterImplTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.debugcounter.DebugCounterServiceTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,009 sec
    [junit] Running net.floodlightcontroller.debugcounter.OFConnectionCountersTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,078 sec
    [junit] Running net.floodlightcontroller.debugevent.DebugEventTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,014 sec
    [junit] Running net.floodlightcontroller.debugevent.EventTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.devicemanager.internal.DeviceManagerImplTest
    [junit] Tests run: 37, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,477 sec
    [junit] Running net.floodlightcontroller.devicemanager.internal.DeviceUniqueIndexTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.firewall.FirewallTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,073 sec
    [junit] Running net.floodlightcontroller.forwarding.ForwardingTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,075 sec
    [junit] Running net.floodlightcontroller.hub.HubTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,006 sec
    [junit] Running net.floodlightcontroller.learningswitch.LearningSwitchTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,016 sec
    [junit] Running net.floodlightcontroller.linkdiscovery.internal.LinkDiscoveryManagerTest
    [junit] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,394 sec
    [junit] Running net.floodlightcontroller.loadbalancer.LoadBalancerTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,044 sec
    [junit] Running net.floodlightcontroller.notification.NotificationTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.packet.BSNTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.DHCPTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.packet.EthernetTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running net.floodlightcontroller.packet.ICMPTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.IPv4Test
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,004 sec
    [junit] Running net.floodlightcontroller.packet.IPv6Test
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.packet.LLDPOrganizationalTLVTest
    [junit] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,012 sec
    [junit] Running net.floodlightcontroller.packet.LLDPTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.PacketTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.packet.SPUDTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.TCPTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.packet.UDPTest
    [junit] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.routing.RouteTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,005 sec
    [junit] Running net.floodlightcontroller.staticflowentry.StaticFlowTests
    [junit] Tests run: 2, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 0,008 sec
    [junit] TEST net.floodlightcontroller.staticflowentry.StaticFlowTests FAILED
    [junit] Running net.floodlightcontroller.storage.memory.tests.MemoryStorageTest
    [junit] Tests run: 29, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,053 sec
    [junit] Running net.floodlightcontroller.topology.TopologyInstanceTest
    [junit] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,029 sec
    [junit] Running net.floodlightcontroller.topology.TopologyManagerTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running net.floodlightcontroller.util.EnumBitmapsTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running net.floodlightcontroller.util.OFMessageDamperTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,124 sec
    [junit] Running net.floodlightcontroller.util.TimedCacheTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,069 sec
    [junit] Running net.floodlightcontroller.virtualnetwork.VirtualNetworkFilterTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,072 sec
    [junit] Running org.sdnplatform.sync.VersionedTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,002 sec
    [junit] Running org.sdnplatform.sync.client.ClientTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,951 sec
    [junit] Running org.sdnplatform.sync.internal.BootstrapTest
    [junit] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50,547 sec
    [junit] Running org.sdnplatform.sync.internal.SyncManagerTest
    [junit] Tests run: 13, Failures: 8, Errors: 0, Skipped: 3, Time elapsed: 15,847 sec
    [junit] TEST org.sdnplatform.sync.internal.SyncManagerTest FAILED
    [junit] Running org.sdnplatform.sync.internal.store.InMemoryStorageEngineTest
    [junit] Tests run: 13, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,514 sec
    [junit] Running org.sdnplatform.sync.internal.store.JacksonStoreTest
    [junit] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,057 sec
    [junit] Running org.sdnplatform.sync.internal.store.JavaDBStorageEngineTest
    [junit] Tests run: 14, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1,578 sec
    [junit] Running org.sdnplatform.sync.internal.store.RemoteStoreTest
    [junit] Tests run: 8, Failures: 0, Errors: 7, Skipped: 0, Time elapsed: 13,244 sec
    [junit] TEST org.sdnplatform.sync.internal.store.RemoteStoreTest FAILED
    [junit] Running org.sdnplatform.sync.internal.version.ClockEntryTest
    [junit] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,001 sec
    [junit] Running org.sdnplatform.sync.internal.version.VectorClockInconsistencyResolverTest
    [junit] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,003 sec
    [junit] Running org.sdnplatform.sync.internal.version.VectorClockTest
    [junit] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0,013 sec
    [junit] Tests FAILED

BUILD FAILED
/home/worm/ForkFloodlight/floodlight/build.xml:223: Unit test(s) failed.  See reports!

SyncManager results:
13:08:12.696 ERROR [i.n.u.ResourceLeakDetector:main] LEAK: You are creating too many HashedWheelTimer instances.  HashedWheelTimer is a shared resource that must be reused across the JVM,so that only a few instances are created.

The value of CHALLENGE_RESPONSE_SECRET needs to be the value of "-alias" option from keytool, as follow:

keytool -genkey -alias AliasChallengeResponse -keystore key.jceks -keypass "PassWord" -storepass "PassWord" -storetype JCEKS

Main changes:

CHALLENGE_RESPONSE_SECRET = "AliasChallengeResponse"; -> hard coded.

Role of switch from floodlightdefault.properties

Treatment of ROLE_STATUS message OF1.4

For Ethernet types not in Ethernet.etherTypeClassMap, the deserialization would set the payload to the whole data array (including the mac addresses and eth type) instead of the rest of the data array.

For example, this would fail to print:

Ethernet l2 = new Ethernet();
l2.setEtherType(EthType.of(65535)); // some type
l2.setSourceMACAddress(MacAddress.of("00:00:00:00:00:01"));
l2.setDestinationMACAddress(MacAddress.BROADCAST);
Data packetData = new Data();
packetData.setData("some string".getBytes());
l2.setPayload(packetData);
byte[] l2bytes = l2.serialize();
Ethernet l2d = new Ethernet();
l2d.deserialize(l2bytes, 0, l2bytes.length);
Data packetDataDeserialized = (Data) l2d.getPayload();
// printing "new String(packetDataDeserialized.getData())" gives "?????"

I ran the JUnit tests in floodlightcontroller.core.internal, floodlightcontroller.core.test and floodlightcontroller.packet. Are there any more relevant tests?

Fix LLDP inport.

In the event the device manger does not yet know an attachment point for a device, the ACL should detect that and perform a noop. Simply checking the length of the SwitchPort[] returned from the device manger should fix the problem. If the length is zero, return; else, proceed.

Include the completion listener in the MockFloodlightProvider

Fixed typo and deprecatedAPI call in the new onMessageConsumed

Modified Forwarding and ForwardingBase to use setInstructions instead of setActions in OF 1.1 or later. New openflowj-2.0.0-SNAPSHOT.jar that duplicates the shortcut used for FlowMod setActions in version 1.3 to versions 1.1, 1.2 and 1.4

Fix OF1.4 table features properties byte-align to 8 bytes. This required a Loxi update. Also updated handshake handler to not use action but instead instructions w/apply-actions.

Added unit test for writing messages while in MASTER/SLAVE. Changed to a blacklist mechanism instead of a whitelist (to match how the spec describes invalid (write) SLAVE messages). Completed invalid SLAVE messages for each OF version.

Updated to properly handle IOFSwitch write()'s while in SLAVE role. TODO: make unit test for trapping invalid messages while in SLAVE. TODO: complete logic for handling valid SLAVE message types per OF version.

We can shutdown gracefully and not wait (as Netty3 did). If not waiting turns out to be a problem, we can wait again.

Fixed a blunder in OFSwitchManager and Controller to allow switches to connect if a server IP isn't explicitly given in floodlihgtdefault.properties. Still can't get sync's bootstrap test to pass. Feels like a race condition b/t update threads.

Fix bug in ActionUtils. OF1.0 transport ports were being parsed as shorts. For ports above 32767, this is bad.

Core ported to Netty 4 along with unit tests. Still need to do sync and some loxi-related compile errors in web.serializers.

OF-DPA init and learning switch functions created. Possible use is commented out in ForwardingBase.java for the time being.