Device manager will have a 5-second time gap to change an attachment point for a host from one broadcast domain to another.

Introduce a convenience method inSameIsland, which is the same as inSameCluster.  In future, they may have different functionalities.

Introduce a method called isConsistent(..) that compares an old attachment and a new attachment point. If the new attachment point is not consistent with the old one, then it has to be learnt by the device manager.

Fix a bug for checking BDDP packet if the packet is not unicast for it to continue down the processing chain.

If the incoming node port is blocked, allow only unicast and BDDP packets to continue down the processing chain.

When the device manager gets cleaned up (or when during topologyChanged), it should consider the time difference between switching from broadcast to non-broadcast attachment points (as they might be previously on two different switches).

Added a DeviceManager REST API. You can use this to see what devices the controller has learned along with their IPs and attachment points.

Conflicts:

	src/main/java/net/floodlightcontroller/devicemanager/internal/DeviceManagerImpl.java

Device manager should implement ITopologyListener to clear out attachment points when topology changes.

(1) Device manager will drop packets (as the first step) if the topology indicates the packet-in port is not allowed for incoming transmissions. (2) Remove a log message from LinkDiscoveryManager. (3) Topology provides a service called isAllowed() that indicates if the port is enabled for incoming and outgoing traffic.  (4) Tests are modified accordingly.

Change device manager to not allow attachment point flapping (there was a bug in the implementation before).  Also, remove some crappy info log from ForwardingBase.

Added a DeviceManager REST API. You can use this to see what devices the controller has learned along with their IPs and attachment points.

We really don't use any feature of the class Short anyways.
toString was limited to 255 ports. Fixed

Attachment point move suppresion when moving from non-broadcast domain port to broadcast domain port wasn't working. Fixed.

Increase the timeout for switching attachment point from non broadcast domain ports to broadcast domain ports to 5 minutes (from 5 seconds).

If the attachment point of device moves too fast from a non-broadcast domain switch port to a broadcast domain switch port, ignore learning and stop processing the packets.

Needed to move threadpool reference into startup()
was in init()

1 - Handle the case where you specify more than one module that provides the same service in the config. Print out an error message saying which ones are conflicting.
2 - If a service has more than one implementation and none are specified in the configuration file print out which modules can be used in the error message.