[BSC-3247] DeviceManager must learn devices correctly when the ethernet destination MAC in an ARP response is different from sender hardware address.  A device corresponding to the sender hardware address and sender protocol address needs to be learned.  Update unit tests accordingly.

[BVS-324] Remove the usage of getAPMap() when retrieving attachmentpoints.  Its use is needed only when computing duplicates.

findbugs stuff (https://github.com/bigswitch/bigswitchcontroller/pull/2616)

NodePortTuple class implements comparable to allow for sorting of nodeport tuples. The sorting is first based on the switch id and then on the port id.

BSC-3210 - floodlight was writing a controller node into cassandra, this is incorrect. So, if the properties file does not contain controller-id set, then floodlight will write localhost, which is causing a third controller node is cassandra. also there is no need for first boot and upgrade to write controller-id into properties files. so cleaning these up.

Need to run "ant eclipse" to get the new settings.

When creating the eclipse project files we also create a project
specific config for FindBugs that sets the exclude file correctly.

Conflicts:

	floodlight/build.xml
	floodlight/src/test/java/net/floodlightcontroller/devicemanager/internal/DeviceManagerImplTest.java

in response to a rest call

Fix NPE in LinkDiscoveryManager.java (https://github.com/bigswitch/bigswitchcontroller/pull/2491)

Bugfix. Should check if portBroadcastDomainLinks contains NodePortTuple, and not long. (https://github.com/bigswitch/bigswitchcontroller/pull/2489)

Fix consistency and rest output for None/null values (https://github.com/bigswitch/bigswitchcontroller/pull/2488)