Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
floodlight
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
croft1
floodlight
Commits
7bdce672
Commit
7bdce672
authored
13 years ago
by
Alex Reimers
Browse files
Options
Downloads
Patches
Plain Diff
Fixed an issue with leaking LLDPs across islands in TopologyImpl.
parent
726aeaf7
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/main/java/net/floodlightcontroller/topology/internal/TopologyImpl.java
+5
-6
5 additions, 6 deletions
.../floodlightcontroller/topology/internal/TopologyImpl.java
with
5 additions
and
6 deletions
src/main/java/net/floodlightcontroller/topology/internal/TopologyImpl.java
+
5
−
6
View file @
7bdce672
...
...
@@ -574,7 +574,10 @@ public class TopologyImpl implements IOFMessageListener, IOFSwitchListener,
if
(
remoteSwitch
==
null
)
{
// Ignore LLDPs not generated by Floodlight, or from a switch that has recently
// disconnected, or from a switch connected to another Floodlight instance
return
Command
.
CONTINUE
;
if
(
log
.
isDebugEnabled
())
{
log
.
debug
(
"Received LLDP from remote switch not connected to the controller"
);
}
return
Command
.
STOP
;
}
if
(!
remoteSwitch
.
portEnabled
(
remotePort
))
{
...
...
@@ -601,7 +604,7 @@ public class TopologyImpl implements IOFMessageListener, IOFSwitchListener,
}
private
Command
handleBpdu
(
BPDU
bpdu
,
IOFSwitch
sw
,
OFPacketIn
pi
)
{
// TODO -
fill this in.
// TODO -
handle STP here
return
Command
.
STOP
;
}
...
...
@@ -620,7 +623,6 @@ public class TopologyImpl implements IOFMessageListener, IOFSwitchListener,
return
Command
.
CONTINUE
;
}
//TODO - we can optimize the updating clusters on a link added
protected
void
addOrUpdateLink
(
LinkTuple
lt
,
int
srcPortState
,
int
dstPortState
)
{
lock
.
writeLock
().
lock
();
...
...
@@ -663,9 +665,6 @@ public class TopologyImpl implements IOFMessageListener, IOFSwitchListener,
updateOperation
=
UpdateOperation
.
ADD
;
linkChanged
=
true
;
if
(
log
.
isTraceEnabled
())
{
log
.
trace
(
"Added link {}"
,
lt
);
}
log
.
info
(
"Added link {}"
,
lt
);
}
else
{
// Only update the port states if they've changed
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment