Merge pull request #83 from nilok/disallow-multiple-providers

Fixing bug which allowed multiple modules that provide a given service to be loaded.

src/main/java/net/floodlightcontroller/core/module/FloodlightModuleLoader.java

@@ -287,8 +287,18 @@ public class FloodlightModuleLoader {
                                      "  as provider for " + 
                                      s.getKey().getCanonicalName());
                     }
-                    floodlightModuleContext.addService(s.getKey(),
-                                                       s.getValue());
+                    if (floodlightModuleContext.getServiceImpl(s.getKey()) == null) {
+                        floodlightModuleContext.addService(s.getKey(),
+                                                           s.getValue());
+                    } else {
+                        throw new FloodlightModuleException("Cannot set "
+                                                            + s.getValue()
+                                                            + " as the provider for "
+                                                            + s.getKey().getCanonicalName()
+                                                            + " because "
+                                                            + floodlightModuleContext.getServiceImpl(s.getKey())
+                                                            + " already provides it");
+                    }
                 }
             }
         }