Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
F
floodlight
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
croft1
floodlight
Commits
4b988c29
Commit
4b988c29
authored
12 years ago
by
Mandeep Dhami
Browse files
Options
Downloads
Patches
Plain Diff
Added check for decode to avoid out of order invocation (wrt to decodeLast)
parent
5129beb5
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/main/java/net/floodlightcontroller/core/internal/OFMessageDecoder.java
+15
-2
15 additions, 2 deletions
.../floodlightcontroller/core/internal/OFMessageDecoder.java
with
15 additions
and
2 deletions
src/main/java/net/floodlightcontroller/core/internal/OFMessageDecoder.java
+
15
−
2
View file @
4b988c29
...
...
@@ -39,9 +39,22 @@ public class OFMessageDecoder extends FrameDecoder {
@Override
protected
Object
decode
(
ChannelHandlerContext
ctx
,
Channel
channel
,
ChannelBuffer
buffer
)
throws
Exception
{
List
<
OFMessage
>
message
=
factory
.
parseMessage
(
buffer
);
if
(!
channel
.
isConnected
())
{
// In testing, I see decode being called AFTER decode last.
// This check avoids that from reading curroupted frames
return
null
;
}
List
<
OFMessage
>
message
=
factory
.
parseMessage
(
buffer
);
return
message
;
}
@Override
protected
Object
decodeLast
(
ChannelHandlerContext
ctx
,
Channel
channel
,
ChannelBuffer
buffer
)
throws
Exception
{
// This is not strictly needed atthis time. It is used to detect
// connection reset detection from netty (for debug)
return
null
;
}
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment