The previous fix is not correct. The fix generates a device moved event when...

The previous fix is not correct.  The fix generates a device moved event when the attachment points are not even updated.

Revert "Device moved notification has to be generated when the new attachment point was already in the oldAP list."

This reverts commit 2d6a75c4116790db7d1ddaa53e0d6d873d035815.

src/main/java/net/floodlightcontroller/devicemanager/internal/Device.java

@@ -464,14 +464,11 @@ public class Device implements IDevice {
         } else  if (oldAPFlag) {
             // retain oldAP  as is.  Put the newAP in oldAPs for flagging
             // possible duplicates.
-            oldAPList = new ArrayList<AttachmentPoint>();
-            if (oldAPs != null) oldAPList.addAll(oldAPs);
-            // Add to oldAPList only if it was picked up from the oldAPList
-            oldAPList.add(newAP);
-            this.oldAPs = oldAPList;
-            if (!topology.isInSameBroadcastDomain(oldAP.getSw(), oldAP.getPort(),
-                                                  newAP.getSw(), newAP.getPort()))
-                return true; // attachment point changed.
+                oldAPList = new ArrayList<AttachmentPoint>();
+                if (oldAPs != null) oldAPList.addAll(oldAPs);
+                // Add ot oldAPList only if it was picked up from the oldAPList
+                oldAPList.add(newAP);
+                this.oldAPs = oldAPList;
         }
         return false;
     }