Revised PacketParsingException class

src/main/java/net/floodlightcontroller/packet/ARP.java

@@ -233,18 +233,14 @@ public class ARP extends BasePacket {
         this.hardwareAddressLength = bb.get();
         this.protocolAddressLength = bb.get();
         if (this.hardwareAddressLength != 6) {
-            if (log.isTraceEnabled()) {
-                log.trace("Incorrect ARP hardware address length: {}",
-                        hardwareAddressLength);
-            }
-            throw new PacketParsingException();
+            String msg = "Incorrect ARP hardware address length: " +
+                        hardwareAddressLength;
+            throw new PacketParsingException(msg);
         }
         if (this.protocolAddressLength != 4) {
-            if (log.isTraceEnabled()) {
-                log.trace("Incorrect ARP protocol address length: {}",
-                        protocolAddressLength);
-            }
-            throw new PacketParsingException();
+            String msg = "Incorrect ARP protocol address length: " +
+                        protocolAddressLength;
+            throw new PacketParsingException(msg);
         }
         this.opCode = bb.getShort();
         this.senderHardwareAddress = new byte[0xff & this.hardwareAddressLength];

src/main/java/net/floodlightcontroller/packet/BSN.java

@@ -102,13 +102,13 @@ public class BSN extends BasePacket {
 
         int magic = bb.getInt();
         if (magic != BSN_MAGIC) {
-            throw new RuntimeException("Invalid BSN magic " + magic);
+            throw new PacketParsingException("Invalid BSN magic " + magic);
         }
 
         this.type = bb.getShort();
         this.version = bb.getShort();
         if (this.version != BSN_VERSION_CURRENT) {
-            throw new RuntimeException(
+            throw new PacketParsingException(
                     "Invalid BSN packet version " + this.version + ", should be "
                     + BSN_VERSION_CURRENT);
         }

src/main/java/net/floodlightcontroller/packet/IPv4.java

@@ -362,7 +362,8 @@ public class IPv4 extends BasePacket {
         this.headerLength = (byte) (this.version & 0xf);
         this.version = (byte) ((this.version >> 4) & 0xf);
         if (this.version != 4) {
-            throw new RuntimeException("Invalid version for IPv4 packet: " +
+            throw new PacketParsingException(
+                    "Invalid version for IPv4 packet: " +
                     this.version);
         }
         this.diffServ = bb.get();

src/main/java/net/floodlightcontroller/packet/PacketParsingException.java

@@ -18,6 +18,10 @@ package net.floodlightcontroller.packet;
 
 public class PacketParsingException extends Exception {
 
+    public PacketParsingException(String msg) {
+        super(msg);
+    }
+
     private static final long serialVersionUID = -1177841297678875573L;
 
-}
+}
\ No newline at end of file

src/main/java/net/floodlightcontroller/packet/TCP.java

@@ -268,7 +268,7 @@ public class TCP extends BasePacket {
         this.flags = bb.getShort();
         this.dataOffset = (byte) ((this.flags >> 12) & 0xf);
         if (this.dataOffset < 5) {
-            throw new RuntimeException("Invalid tcp header length < 20");
+            throw new PacketParsingException("Invalid tcp header length < 20");
         }
         this.flags = (short) (this.flags & 0x1ff);
         this.windowSize = bb.getShort();