Skip to content
Snippets Groups Projects

updated to use new Annotator API, added Configurator classes

Merged Mark Sammons requested to merge mssammon into master

Updated to conform to updated Annotator API. Added configurator classes to bring configuration in line with other CCG packages and make integration into pipeline more straightforward. Note that I also updated to Gurobi 6.5. This can be rolled back to 6.0 if preferred.

Merge request reports

Approval is optional

Merged by avatar (Mar 13, 2025 9:42pm UTC)

Merge details

  • Changes merged into master with 4d9070ac.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @christos I'm having serious problems with conflicts between SRLType and ViewNames.SRL_NOM/.SRL_VERB. The tests pass, but when I try to integrate into the nlp pipeline, I get errors about the view "Verb" not being present. I'm trying to figure out where this happens now. Generally, the construction system seems overcomplicated -- I don't think I made it worse, but nor have I really improved it much. The annotator itself throws an exception because this view is not found -- I'd appreciate it if you can try to make the SRL code behave in a way that conforms with our earlier agreement about CCG Annotators w.r.t. the names of the Views it creates, but I'll accept whatever allows it to integrate cleanly with pipeline. I'm pushing my most recent changes to illinois-srl and to illinois-nlp-pipeline so you can see for yourself.

    Edited by Mark Sammons
  • Mark Sammons Added 2 commits:

    Added 2 commits:

    • db4f56d3 - updated SRL constructors to use ResourceManagers correctly
    • d94ab6b5 - Trying to make SRL conform to expected Annotator behavior, using ViewNames.SRL_VERB etc.
  • @christos I've pushed updates to branch mssammon on illinois-nlp-pipeline so you can test integration.

  • Added 1 commit:

    • 8c5b1064 - Minor changes for pipeline support
  • Added 1 commit:

  • @mssammon I have pushed some small changes here and to illinois-nlp-pipeline, but I can't run mvn test because it runs out of memory (both on my laptop and my desktop -- even after I turned NER_CONLL off)

    It might work now (it might have been this fix in the configurator), but there is a bigger issue: SRL is the first packages that has true required views. Up to this point there was no way of ensuring that the required views are populated before calling a specific Annotator. I added a check during addView but I wouldn't want to call the pipeline's Annotators from within SRL. A related but minor issue is that there is a cyclical dependency in the pipeline now, since SRL has it as a dependency for its preprocessor.

  • @christod Happy Hollydays. You want I should merge this/update version/deploy? -- after minor fixes it appears to be running now...

    Edited by Mark Sammons
  • @mssammon happy holidays! If you are satisfied with the integration I'm more than happy to merge (you need to remove the WIP flag). If possible, could you also merge !7 (merged) as well before updating version/deploying?

  • Mark Sammons Added 3 commits:

    Added 3 commits:

    • e191bdfc - Created a bypass for getting top-k predictions before the ILP
    • 298fa23f - Removed pred-arg evaluator
    • 4d9070ac - Merge remote-tracking branch 'remotes/origin/christos-ilp-updates' into mssammon
  • Mark Sammons Title changed from WIP: updated to use new Annotator API, added Configurator classes to updated to use new Annotator API, added Configurator classes

    Title changed from WIP: updated to use new Annotator API, added Configurator classes to updated to use new Annotator API, added Configurator classes

  • Mark Sammons mentioned in commit 48e310d2

    mentioned in commit 48e310d2

  • Mark Sammons Status changed to merged

    Status changed to merged

  • mentioned in issue #3 (closed)

  • Please register or sign in to reply
    Loading