From 6247c28d2c1bb33b940cb4e96139b2c25ee117d7 Mon Sep 17 00:00:00 2001
From: RafaeNoor <abdurrafae98@live.com>
Date: Mon, 11 Apr 2022 14:05:46 -0500
Subject: [PATCH] Incorporating Ying's suggestions
---
hpvm/CMakeLists.txt | 8 ++++----
hpvm/docs/build-hpvm.rst | 4 ++--
hpvm/docs/how_to_guides/port-to-hpvm-c.rst | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hpvm/CMakeLists.txt b/hpvm/CMakeLists.txt
index 7acf2a50db..52ab9751ac 100644
--- a/hpvm/CMakeLists.txt
+++ b/hpvm/CMakeLists.txt
@@ -7,8 +7,8 @@ function(getTargets foundTargets dirs)
if(targetlist)
foreach(target ${targetlist})
get_target_property(target_type ${target} TYPE)
- if ((${target_type} STREQUAL "EXECUTABLE")
- OR (${target_type} STREQUAL "MODULE_LIBRARY")
+ if ((${target_type} STREQUAL "EXECUTABLE")
+ OR (${target_type} STREQUAL "MODULE_LIBRARY")
OR (${target_type} STREQUAL "STATIC_LIBRARY"))
list(APPEND targets ${target})
endif()
@@ -33,8 +33,8 @@ endfunction()
if (NOT CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
message(FATAL_ERROR "Please use GCC as compiler!")
endif()
-if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 5.1)
- message(FATAL_ERROR "ONLY GCC VERSION 5.1 or GREATER IS SUPPORTED!")
+if(CMAKE_CXX_COMPILER_VERSION VERSION_LESS 7.0)
+ message(FATAL_ERROR "ONLY GCC VERSION 7.0 or GREATER IS SUPPORTED!")
endif()
include(CheckLanguage)
diff --git a/hpvm/docs/build-hpvm.rst b/hpvm/docs/build-hpvm.rst
index 63c290e490..1a0dc7e88d 100644
--- a/hpvm/docs/build-hpvm.rst
+++ b/hpvm/docs/build-hpvm.rst
@@ -6,7 +6,7 @@ Dependencies
* The following components are required for building HPVM:
- * GCC (>=5.1)
+ * GCC (>=7.0)
* CMake (>=3.17)
@@ -114,7 +114,7 @@ First, checkout HPVM and navigate to ``<root>/hpvm``:
.. code-block:: shell
git clone --recursive -b main https://gitlab.engr.illinois.edu/llvm/hpvm-release.git
- cd hpvm/hpvm/
+ cd hpvm-release/hpvm/
If you have already cloned the repository without using ``--recursive``,
the directory ``hpvm/projects/predtuner`` should be empty,
diff --git a/hpvm/docs/how_to_guides/port-to-hpvm-c.rst b/hpvm/docs/how_to_guides/port-to-hpvm-c.rst
index 19923c51db..697737f419 100644
--- a/hpvm/docs/how_to_guides/port-to-hpvm-c.rst
+++ b/hpvm/docs/how_to_guides/port-to-hpvm-c.rst
@@ -1,7 +1,7 @@
Porting a Program from C to HPVM-C
==================================
-The following represents the required steps to port a regular C program into an HPVM program with HPVM-C. These steps are described at a high level; for more detail, please see `hpvm-cava </hpvm/benchmarks/general_benchmarks/hpvm-cava>`_ provided in `general benchmarks </hpvm/benchmarks/general_benchmarks>`_.
+The following represents the required steps to port a regular C program into an HPVM program with HPVM-C. These steps are described at a high level; for more detail, please see `hpvm-cava <https://gitlab.engr.illinois.edu/llvm/hpvm-release/-/tree/main/hpvm/benchmarks/general_benchmarks/hpvm-cava>`_ provided in `general benchmarks <https://gitlab.engr.illinois.edu/llvm/hpvm-release/-/tree/main/hpvm/benchmarks/general_benchmarks>`_.
* Separate the computation that will become a kernel into its own (leaf node) function and add the attributes and target hint.
* Create a level 1 wrapper node function that will describe the thread-level parallelism (for the GPU). The node will:
--
GitLab