diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala index 6ba8b33b3fa74e807ced977c09618bfd41b0fa07..2679e026bb00a00383350e4da688b111c9623938 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala @@ -545,7 +545,7 @@ object CollapseRepartition extends Rule[LogicalPlan] { object CollapseWindow extends Rule[LogicalPlan] { def apply(plan: LogicalPlan): LogicalPlan = plan transformUp { case w @ Window(we1, ps1, os1, Window(we2, ps2, os2, grandChild)) if ps1 == ps2 && os1 == os2 => - w.copy(windowExpressions = we1 ++ we2, child = grandChild) + w.copy(windowExpressions = we2 ++ we1, child = grandChild) } } diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala index 797076e55cfccb4905400c7bce6e721a27701d2e..3f7d1d9fd99afa3c8cc6c76bb8589a164cf71a44 100644 --- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala +++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/CollapseWindowSuite.scala @@ -46,12 +46,15 @@ class CollapseWindowSuite extends PlanTest { .window(Seq(sum(b).as('sum_b)), partitionSpec1, orderSpec1) .window(Seq(avg(b).as('avg_b)), partitionSpec1, orderSpec1) - val optimized = Optimize.execute(query.analyze) + val analyzed = query.analyze + val optimized = Optimize.execute(analyzed) + assert(analyzed.output === optimized.output) + val correctAnswer = testRelation.window(Seq( - avg(b).as('avg_b), - sum(b).as('sum_b), - max(a).as('max_a), - min(a).as('min_a)), partitionSpec1, orderSpec1) + min(a).as('min_a), + max(a).as('max_a), + sum(b).as('sum_b), + avg(b).as('avg_b)), partitionSpec1, orderSpec1) comparePlans(optimized, correctAnswer) }