From d4895c9de6ca9c3ac4461cf6f86cd88eb63e0720 Mon Sep 17 00:00:00 2001 From: liuxian <liu.xian3@zte.com.cn> Date: Wed, 30 Aug 2017 10:16:11 +0100 Subject: [PATCH] [MINOR][TEST] Off -heap memory leaks for unit tests ## What changes were proposed in this pull request? Free off -heap memory . I have checked all the unit tests. ## How was this patch tested? N/A Author: liuxian <liu.xian3@zte.com.cn> Closes #19075 from 10110346/memleak. --- .../src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java | 1 + .../java/org/apache/spark/memory/TaskMemoryManagerSuite.java | 1 + 2 files changed, 2 insertions(+) diff --git a/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java b/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java index a77ba826fc..4ae49d82ef 100644 --- a/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java +++ b/common/unsafe/src/test/java/org/apache/spark/unsafe/PlatformUtilSuite.java @@ -73,5 +73,6 @@ public class PlatformUtilSuite { Assert.assertEquals( Platform.getByte(offheap.getBaseObject(), offheap.getBaseOffset()), MemoryAllocator.MEMORY_DEBUG_FILL_CLEAN_VALUE); + MemoryAllocator.UNSAFE.free(offheap); } } diff --git a/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java b/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java index f53bc0b02b..46b0516e36 100644 --- a/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java +++ b/core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java @@ -54,6 +54,7 @@ public class TaskMemoryManagerSuite { final long encodedAddress = manager.encodePageNumberAndOffset(dataPage, offset); Assert.assertEquals(null, manager.getPage(encodedAddress)); Assert.assertEquals(offset, manager.getOffsetInPage(encodedAddress)); + manager.freePage(dataPage, c); } @Test -- GitLab