diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala index 6fc154f8debcf9d29c613566bef96e996b0afc60..d2042ad00a8167e43c306fab3110524be6ffc9a2 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/FunctionRegistry.scala @@ -234,6 +234,7 @@ object FunctionRegistry { expression[StringToMap]("str_to_map"), expression[Sqrt]("sqrt"), expression[Tan]("tan"), + expression[Cot]("cot"), expression[Tanh]("tanh"), expression[Add]("+"), diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala index de1a46dc478050652201b4e10c889a41d3e35739..a7bf81e98be8e315a582c307539664c6334fcc03 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/mathExpressions.scala @@ -543,6 +543,20 @@ case class Sqrt(child: Expression) extends UnaryMathExpression(math.sqrt, "SQRT" """) case class Tan(child: Expression) extends UnaryMathExpression(math.tan, "TAN") +@ExpressionDescription( + usage = "_FUNC_(expr) - Returns the cotangent of `expr`.", + extended = """ + Examples: + > SELECT _FUNC_(1); + 0.6420926159343306 + """) +case class Cot(child: Expression) + extends UnaryMathExpression((x: Double) => 1 / math.tan(x), "COT") { + override def doGenCode(ctx: CodegenContext, ev: ExprCode): ExprCode = { + defineCodeGen(ctx, ev, c => s"${ev.value} = 1 / java.lang.Math.tan($c);") + } +} + @ExpressionDescription( usage = "_FUNC_(expr) - Returns the hyperbolic tangent of `expr`.", extended = """ diff --git a/sql/core/src/test/resources/sql-tests/inputs/operators.sql b/sql/core/src/test/resources/sql-tests/inputs/operators.sql index 6339d69ca6473ff1765c768b6ea47175374e194f..1920a108c658419dbf5b7908b569f2a44a6110d1 100644 --- a/sql/core/src/test/resources/sql-tests/inputs/operators.sql +++ b/sql/core/src/test/resources/sql-tests/inputs/operators.sql @@ -53,3 +53,9 @@ explain select 2 * 4 + 3 || 'b'; explain select 3 + 1 || 'a' || 4 / 2; explain select 1 == 1 OR 'a' || 'b' == 'ab'; explain select 'a' || 'c' == 'ac' AND 2 == 3; + +-- math functions +select cot(1); +select cot(null); +select cot(0); +select cot(-1); diff --git a/sql/core/src/test/resources/sql-tests/results/operators.sql.out b/sql/core/src/test/resources/sql-tests/results/operators.sql.out index e0236f41187ec40e9469035f8bbf2579b7fbc1d4..abd18211c70d8a025f4090c35849c603c3cfe089 100644 --- a/sql/core/src/test/resources/sql-tests/results/operators.sql.out +++ b/sql/core/src/test/resources/sql-tests/results/operators.sql.out @@ -1,5 +1,5 @@ -- Automatically generated by SQLQueryTestSuite --- Number of queries: 34 +-- Number of queries: 38 -- !query 0 @@ -284,3 +284,35 @@ struct<plan:string> == Physical Plan == *Project [false AS ((concat(a, c) = ac) AND (2 = 3))#x] +- Scan OneRowRelation[] + + +-- !query 34 +select cot(1) +-- !query 34 schema +struct<COT(CAST(1 AS DOUBLE)):double> +-- !query 34 output +0.6420926159343306 + + +-- !query 35 +select cot(null) +-- !query 35 schema +struct<COT(CAST(NULL AS DOUBLE)):double> +-- !query 35 output +NULL + + +-- !query 36 +select cot(0) +-- !query 36 schema +struct<COT(CAST(0 AS DOUBLE)):double> +-- !query 36 output +Infinity + + +-- !query 37 +select cot(-1) +-- !query 37 schema +struct<COT(CAST(-1 AS DOUBLE)):double> +-- !query 37 output +-0.6420926159343306