From bcc7373f673d1a51b48fb95432ba5c4644dd5d23 Mon Sep 17 00:00:00 2001
From: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Date: Thu, 14 Jan 2016 10:43:39 -0800
Subject: [PATCH] [SPARK-12821][BUILD] Style checker should run when some
configuration files for style are modified but any source files are not.
When running the `run-tests` script, style checkers run only when any source files are modified but they should run when configuration files related to style are modified.
Author: Kousuke Saruta <sarutak@oss.nttdata.co.jp>
Closes #10754 from sarutak/SPARK-12821.
---
dev/run-tests.py | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/dev/run-tests.py b/dev/run-tests.py
index 8726889cbc..795db0dcfb 100755
--- a/dev/run-tests.py
+++ b/dev/run-tests.py
@@ -529,9 +529,14 @@ def main():
run_apache_rat_checks()
# style checks
- if not changed_files or any(f.endswith(".scala") for f in changed_files):
+ if not changed_files or any(f.endswith(".scala")
+ or f.endswith("scalastyle-config.xml")
+ for f in changed_files):
run_scala_style_checks()
- if not changed_files or any(f.endswith(".java") for f in changed_files):
+ if not changed_files or any(f.endswith(".java")
+ or f.endswith("checkstyle.xml")
+ or f.endswith("checkstyle-suppressions.xml")
+ for f in changed_files):
# run_java_style_checks()
pass
if not changed_files or any(f.endswith(".py") for f in changed_files):
--
GitLab