diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala index e67f2be6d237ea554756947fca8dfa5d2fa62631..b108017c4c482720419c91a8ddba6f1b447769b5 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/QueryPlan.scala @@ -24,15 +24,6 @@ import org.apache.spark.sql.types.{DataType, StructType} abstract class QueryPlan[PlanType <: QueryPlan[PlanType]] extends TreeNode[PlanType] { self: PlanType => - /** - * Override [[TreeNode.apply]] to so we can return a more narrow type. - * - * Note that this cannot return BaseType because logical plan's plan node might return - * physical plan for innerChildren, e.g. in-memory relation logical plan node has a reference - * to the physical plan node it is referencing. - */ - override def apply(number: Int): QueryPlan[_] = super.apply(number).asInstanceOf[QueryPlan[_]] - def output: Seq[Attribute] /** diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala index 670fa2bc8de8eeef84b2c91979759d40fd58722a..8cc16d662b6032f4e724294eb14904036a181045 100644 --- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala +++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/trees/TreeNode.scala @@ -498,7 +498,7 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product { treeString.split("\n").zipWithIndex.map { case (line, i) => f"$i%02d $line" }.mkString("\n") /** - * Returns the tree node at the specified number. + * Returns the tree node at the specified number, used primarily for interactive debugging. * Numbers for each node can be found in the [[numberedTreeString]]. * * Note that this cannot return BaseType because logical plan's plan node might return @@ -507,6 +507,14 @@ abstract class TreeNode[BaseType <: TreeNode[BaseType]] extends Product { */ def apply(number: Int): TreeNode[_] = getNodeNumbered(new MutableInt(number)).orNull + /** + * Returns the tree node at the specified number, used primarily for interactive debugging. + * Numbers for each node can be found in the [[numberedTreeString]]. + * + * This is a variant of [[apply]] that returns the node as BaseType (if the type matches). + */ + def p(number: Int): BaseType = apply(number).asInstanceOf[BaseType] + private def getNodeNumbered(number: MutableInt): Option[TreeNode[_]] = { if (number.i < 0) { None