From 9cea0c28184c86625f8281eea2af77eff15acb73 Mon Sep 17 00:00:00 2001
From: Andrew xia <junluan.xia@intel.com>
Date: Mon, 1 Jul 2013 22:22:29 +0800
Subject: [PATCH] Refactor metricsSystem unit test, add resource files.
---
.../resources/test_metrics_config.properties | 6 ++++
.../resources/test_metrics_system.properties | 7 +++++
.../spark/metrics/MetricsConfigSuite.scala | 30 ++----------------
.../spark/metrics/MetricsSystemSuite.scala | 31 ++-----------------
4 files changed, 19 insertions(+), 55 deletions(-)
create mode 100644 core/src/test/resources/test_metrics_config.properties
create mode 100644 core/src/test/resources/test_metrics_system.properties
diff --git a/core/src/test/resources/test_metrics_config.properties b/core/src/test/resources/test_metrics_config.properties
new file mode 100644
index 0000000000..2011940003
--- /dev/null
+++ b/core/src/test/resources/test_metrics_config.properties
@@ -0,0 +1,6 @@
+*.sink.console.period = 10
+*.sink.console.unit = second
+*.source.jvm.class = spark.metrics.source.JvmSource
+master.sink.console.period = 20
+master.sink.console.unit = minute
+
diff --git a/core/src/test/resources/test_metrics_system.properties b/core/src/test/resources/test_metrics_system.properties
new file mode 100644
index 0000000000..06afbc6625
--- /dev/null
+++ b/core/src/test/resources/test_metrics_system.properties
@@ -0,0 +1,7 @@
+*.sink.console.period = 10
+*.sink.console.unit = second
+test.sink.console.class = spark.metrics.sink.ConsoleSink
+test.sink.dummy.class = spark.metrics.sink.DummySink
+test.source.dummy.class = spark.metrics.source.DummySource
+test.sink.console.period = 20
+test.sink.console.unit = minute
diff --git a/core/src/test/scala/spark/metrics/MetricsConfigSuite.scala b/core/src/test/scala/spark/metrics/MetricsConfigSuite.scala
index 0c7142c418..f4c83cb644 100644
--- a/core/src/test/scala/spark/metrics/MetricsConfigSuite.scala
+++ b/core/src/test/scala/spark/metrics/MetricsConfigSuite.scala
@@ -11,24 +11,7 @@ class MetricsConfigSuite extends FunSuite with BeforeAndAfter {
var filePath: String = _
before {
- val prop = new Properties()
-
- prop.setProperty("*.sink.console.period", "10")
- prop.setProperty("*.sink.console.unit", "second")
- prop.setProperty("*.source.jvm.class", "spark.metrics.source.JvmSource")
- prop.setProperty("master.sink.console.period", "20")
- prop.setProperty("master.sink.console.unit", "minute")
-
- val dir = new File("/tmp")
- filePath = if (dir.isDirectory() && dir.exists() && dir.canWrite()) {
- "/tmp/test_metrics.properties"
- } else {
- "./test_metrics.properties"
- }
-
- val os = new FileOutputStream(new File(filePath))
- prop.store(os, "for test")
- os.close()
+ filePath = getClass.getClassLoader.getResource("test_metrics_config.properties").getFile()
}
test("MetricsConfig with default properties") {
@@ -81,12 +64,5 @@ class MetricsConfigSuite extends FunSuite with BeforeAndAfter {
val jmxProps = sinkProps("jmx")
assert(jmxProps.size() === 1)
- }
-
- after {
- val file = new File(filePath)
- if (file.exists()) {
- file.delete()
- }
- }
-}
\ No newline at end of file
+ }
+}
diff --git a/core/src/test/scala/spark/metrics/MetricsSystemSuite.scala b/core/src/test/scala/spark/metrics/MetricsSystemSuite.scala
index 5e8f8fcf80..967be6ec47 100644
--- a/core/src/test/scala/spark/metrics/MetricsSystemSuite.scala
+++ b/core/src/test/scala/spark/metrics/MetricsSystemSuite.scala
@@ -11,25 +11,7 @@ class MetricsSystemSuite extends FunSuite with BeforeAndAfter {
var filePath: String = _
before {
- val props = new Properties()
- props.setProperty("*.sink.console.period", "10")
- props.setProperty("*.sink.console.unit", "second")
- props.setProperty("test.sink.console.class", "spark.metrics.sink.ConsoleSink")
- props.setProperty("test.sink.dummy.class", "spark.metrics.sink.DummySink")
- props.setProperty("test.source.dummy.class", "spark.metrics.source.DummySource")
- props.setProperty("test.sink.console.period", "20")
- props.setProperty("test.sink.console.unit", "minute")
-
- val dir = new File("/tmp")
- filePath = if (dir.isDirectory() && dir.exists() && dir.canWrite()) {
- "/tmp/test_metrics.properties"
- } else {
- "./test_metrics.properties"
- }
-
- val os = new FileOutputStream(new File(filePath))
- props.store(os, "for test")
- os.close()
+ filePath = getClass.getClassLoader.getResource("test_metrics_system.properties").getFile()
System.setProperty("spark.metrics.conf.file", filePath)
}
@@ -54,12 +36,5 @@ class MetricsSystemSuite extends FunSuite with BeforeAndAfter {
val source = new spark.deploy.master.MasterInstrumentation(null)
metricsSystem.registerSource(source)
assert(sources.length === 2)
- }
-
- after {
- val file = new File(filePath)
- if (file.exists()) {
- file.delete()
- }
- }
-}
\ No newline at end of file
+ }
+}
--
GitLab