From 8121a4b1cb4d7efa84a5e9e8e16d6656cdb79b85 Mon Sep 17 00:00:00 2001
From: Herman van Hovell <hvanhovell@questtec.nl>
Date: Thu, 11 Feb 2016 18:23:44 -0800
Subject: [PATCH] [SPARK-13277][BUILD] Follow-up ANTLR warnings are treated as
build errors
It is possible to create faulty but legal ANTLR grammars. ANTLR will produce warnings but also a valid compileable parser. This PR makes sure we treat such warnings as build errors.
cc rxin / viirya
Author: Herman van Hovell <hvanhovell@questtec.nl>
Closes #11174 from hvanhovell/ANTLR-warnings-as-errors.
---
project/SparkBuild.scala | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/project/SparkBuild.scala b/project/SparkBuild.scala
index 550b5bad8a..6eba58c87c 100644
--- a/project/SparkBuild.scala
+++ b/project/SparkBuild.scala
@@ -433,9 +433,12 @@ object Catalyst {
}
// Generate the parser.
- antlr.process
- if (antlr.getNumErrors > 0) {
- log.error("ANTLR: Caught %d build errors.".format(antlr.getNumErrors))
+ antlr.process()
+ val errorState = org.antlr.tool.ErrorManager.getErrorState
+ if (errorState.errors > 0) {
+ sys.error("ANTLR: Caught %d build errors.".format(errorState.errors))
+ } else if (errorState.warnings > 0) {
+ sys.error("ANTLR: Caught %d build warnings.".format(errorState.warnings))
}
// Return all generated java files.
--
GitLab