From 7a89f2adbbc82a23f06638806ffc8596a7efe7f3 Mon Sep 17 00:00:00 2001
From: Cheng Lian <lian@databricks.com>
Date: Thu, 16 Jun 2016 14:20:44 -0700
Subject: [PATCH] [SQL] Minor HashAggregateExec string output fixes
## What changes were proposed in this pull request?
This PR fixes some minor `.toString` format issues for `HashAggregateExec`.
Before:
```
*HashAggregate(key=[a#234L,b#235L], functions=[count(1),max(c#236L)], output=[a#234L,b#235L,count(c)#247L,max(c)#248L])
```
After:
```
*HashAggregate(keys=[a#234L, b#235L], functions=[count(1), max(c#236L)], output=[a#234L, b#235L, count(c)#247L, max(c)#248L])
```
## How was this patch tested?
Manually tested.
Author: Cheng Lian <lian@databricks.com>
Closes #13710 from liancheng/minor-agg-string-fix.
---
.../sql/execution/aggregate/HashAggregateExec.scala | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala b/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
index caeeba1793..54d7340d8a 100644
--- a/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
+++ b/sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
@@ -774,13 +774,13 @@ case class HashAggregateExec(
testFallbackStartsAt match {
case None =>
- val keyString = Utils.truncatedString(groupingExpressions, "[", ",", "]")
- val functionString = Utils.truncatedString(allAggregateExpressions, "[", ",", "]")
- val outputString = Utils.truncatedString(output, "[", ",", "]")
+ val keyString = Utils.truncatedString(groupingExpressions, "[", ", ", "]")
+ val functionString = Utils.truncatedString(allAggregateExpressions, "[", ", ", "]")
+ val outputString = Utils.truncatedString(output, "[", ", ", "]")
if (verbose) {
- s"HashAggregate(key=$keyString, functions=$functionString, output=$outputString)"
+ s"HashAggregate(keys=$keyString, functions=$functionString, output=$outputString)"
} else {
- s"HashAggregate(key=$keyString, functions=$functionString)"
+ s"HashAggregate(keys=$keyString, functions=$functionString)"
}
case Some(fallbackStartsAt) =>
s"HashAggregateWithControlledFallback $groupingExpressions " +
--
GitLab