From 79e2caa1328843457841d71642b60be919ebb1e0 Mon Sep 17 00:00:00 2001 From: gatorsmile <gatorsmile@gmail.com> Date: Fri, 12 Aug 2016 10:02:00 +0100 Subject: [PATCH] [SPARK-16598][SQL][TEST] Added a test case for verifying the table identifier parsing #### What changes were proposed in this pull request? So far, the test cases of `TableIdentifierParserSuite` do not cover the quoted cases. We should add one for avoiding regression. #### How was this patch tested? N/A Author: gatorsmile <gatorsmile@gmail.com> Closes #14244 from gatorsmile/quotedIdentifiers. --- .../sql/catalyst/parser/TableIdentifierParserSuite.scala | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala index 8bbf87e62d..dadb8a8def 100644 --- a/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala +++ b/sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/TableIdentifierParserSuite.scala @@ -68,6 +68,14 @@ class TableIdentifierParserSuite extends SparkFunSuite { } } + test("quoted identifiers") { + assert(TableIdentifier("z", Some("x.y")) === parseTableIdentifier("`x.y`.z")) + assert(TableIdentifier("y.z", Some("x")) === parseTableIdentifier("x.`y.z`")) + assert(TableIdentifier("z", Some("`x.y`")) === parseTableIdentifier("```x.y```.z")) + assert(TableIdentifier("`y.z`", Some("x")) === parseTableIdentifier("x.```y.z```")) + assert(TableIdentifier("x.y.z", None) === parseTableIdentifier("`x.y.z`")) + } + test("table identifier - strict keywords") { // SQL Keywords. hiveStrictNonReservedKeyword.foreach { keyword => -- GitLab