From 69cb0496974737347e2650cda436b39bbd51e581 Mon Sep 17 00:00:00 2001
From: Daniel Darabos <darabos.daniel@gmail.com>
Date: Sat, 17 Sep 2016 12:28:42 +0100
Subject: [PATCH] Correct fetchsize property name in docs
## What changes were proposed in this pull request?
Replace `fetchSize` with `fetchsize` in the docs.
## How was this patch tested?
I manually tested `fetchSize` and `fetchsize`. The latter has an effect. See also [`JdbcUtils.scala#L38`](https://github.com/apache/spark/blob/v2.0.0/sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/jdbc/JdbcUtils.scala#L38) for the definition of the property.
Author: Daniel Darabos <darabos.daniel@gmail.com>
Closes #14975 from darabos/patch-3.
---
docs/sql-programming-guide.md | 2 +-
.../test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/docs/sql-programming-guide.md b/docs/sql-programming-guide.md
index 28cc88c322..4ac5fae566 100644
--- a/docs/sql-programming-guide.md
+++ b/docs/sql-programming-guide.md
@@ -1053,7 +1053,7 @@ the Data Sources API. The following options are supported:
</tr>
<tr>
- <td><code>fetchSize</code></td>
+ <td><code>fetchsize</code></td>
<td>
The JDBC fetch size, which determines how many rows to fetch per round trip. This can help performance on JDBC drivers which default to low fetch size (eg. Oracle with 10 rows).
</td>
diff --git a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala b/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
index 2d8ee338a9..10f15ca280 100644
--- a/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
+++ b/sql/core/src/test/scala/org/apache/spark/sql/jdbc/JDBCSuite.scala
@@ -289,7 +289,7 @@ class JDBCSuite extends SparkFunSuite
assert(names(2).equals("mary"))
}
- test("SELECT first field when fetchSize is two") {
+ test("SELECT first field when fetchsize is two") {
val names = sql("SELECT NAME FROM fetchtwo").collect().map(x => x.getString(0)).sortWith(_ < _)
assert(names.size === 3)
assert(names(0).equals("fred"))
@@ -305,7 +305,7 @@ class JDBCSuite extends SparkFunSuite
assert(ids(2) === 3)
}
- test("SELECT second field when fetchSize is two") {
+ test("SELECT second field when fetchsize is two") {
val ids = sql("SELECT THEID FROM fetchtwo").collect().map(x => x.getInt(0)).sortWith(_ < _)
assert(ids.size === 3)
assert(ids(0) === 1)
@@ -352,7 +352,7 @@ class JDBCSuite extends SparkFunSuite
urlWithUserAndPass, "TEST.PEOPLE", new Properties()).collect().length === 3)
}
- test("Basic API with illegal FetchSize") {
+ test("Basic API with illegal fetchsize") {
val properties = new Properties()
properties.setProperty(JdbcUtils.JDBC_BATCH_FETCH_SIZE, "-1")
val e = intercept[SparkException] {
--
GitLab