From 4d4cbc034bef559f47f8b74cecd8196dc8a85348 Mon Sep 17 00:00:00 2001
From: Huaxin Gao <huaxing@oc0558782468.ibm.com>
Date: Thu, 26 Nov 2015 19:17:46 -0800
Subject: [PATCH] [SPARK-11778][SQL] add regression test
Fix regression test for SPARK-11778.
marmbrus
Could you please take a look?
Thank you very much!!
Author: Huaxin Gao <huaxing@oc0558782468.ibm.com>
Closes #9890 from huaxingao/spark-11778-regression-test.
---
.../hive/HiveDataFrameAnalyticsSuite.scala | 10 ------
.../spark/sql/hive/HiveDataFrameSuite.scala | 32 +++++++++++++++++++
2 files changed, 32 insertions(+), 10 deletions(-)
create mode 100644 sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
index f19a74d4b3..9864acf765 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameAnalyticsSuite.scala
@@ -34,14 +34,10 @@ class HiveDataFrameAnalyticsSuite extends QueryTest with TestHiveSingleton with
override def beforeAll() {
testData = Seq((1, 2), (2, 2), (3, 4)).toDF("a", "b")
hiveContext.registerDataFrameAsTable(testData, "mytable")
- hiveContext.sql("create schema usrdb")
- hiveContext.sql("create table usrdb.test(c1 int)")
}
override def afterAll(): Unit = {
hiveContext.dropTempTable("mytable")
- hiveContext.sql("drop table usrdb.test")
- hiveContext.sql("drop schema usrdb")
}
test("rollup") {
@@ -78,10 +74,4 @@ class HiveDataFrameAnalyticsSuite extends QueryTest with TestHiveSingleton with
sql("select a, b, sum(b) from mytable group by a, b with cube").collect()
)
}
-
- // There was a bug in DataFrameFrameReader.table and it has problem for table with schema name,
- // Before fix, it throw Exceptionorg.apache.spark.sql.catalyst.analysis.NoSuchTableException
- test("table name with schema") {
- hiveContext.read.table("usrdb.test")
- }
}
diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
new file mode 100644
index 0000000000..7fdc5d7193
--- /dev/null
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveDataFrameSuite.scala
@@ -0,0 +1,32 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hive
+
+import org.apache.spark.sql.hive.test.TestHiveSingleton
+import org.apache.spark.sql.QueryTest
+
+class HiveDataFrameSuite extends QueryTest with TestHiveSingleton {
+ test("table name with schema") {
+ // regression test for SPARK-11778
+ hiveContext.sql("create schema usrdb")
+ hiveContext.sql("create table usrdb.test(c int)")
+ hiveContext.read.table("usrdb.test")
+ hiveContext.sql("drop table usrdb.test")
+ hiveContext.sql("drop schema usrdb")
+ }
+}
--
GitLab