Skip to content
Snippets Groups Projects
Commit 4c5889e8 authored by Nicholas Chammas's avatar Nicholas Chammas Committed by Sean Owen
Browse files

[SPARK-8316] Upgrade to Maven 3.3.3

Versions of Maven older than 3.3.0 apparently have [a bug in how they handle transitive dependencies](https://github.com/apache/spark/pull/6492#issuecomment-111001101).

I confirmed that upgrading to Maven 3.3.3 resolves at least the particular manifestation of this bug that I ran into.

Author: Nicholas Chammas <nicholas.chammas@gmail.com>

Closes #6770 from nchammas/maven-333 and squashes the following commits:

6bed2d9 [Nicholas Chammas] upgrade to Maven 3.3.3
parent 4eb48ed1
No related branches found
No related tags found
No related merge requests found
...@@ -69,11 +69,14 @@ install_app() { ...@@ -69,11 +69,14 @@ install_app() {
# Install maven under the build/ folder # Install maven under the build/ folder
install_mvn() { install_mvn() {
local MVN_VERSION="3.3.3"
install_app \ install_app \
"http://archive.apache.org/dist/maven/maven-3/3.2.5/binaries" \ "http://archive.apache.org/dist/maven/maven-3/${MVN_VERSION}/binaries" \
"apache-maven-3.2.5-bin.tar.gz" \ "apache-maven-${MVN_VERSION}-bin.tar.gz" \
"apache-maven-3.2.5/bin/mvn" "apache-maven-${MVN_VERSION}/bin/mvn"
MVN_BIN="${_DIR}/apache-maven-3.2.5/bin/mvn"
MVN_BIN="${_DIR}/apache-maven-${MVN_VERSION}/bin/mvn"
} }
# Install zinc under the build/ folder # Install zinc under the build/ folder
...@@ -105,28 +108,16 @@ install_scala() { ...@@ -105,28 +108,16 @@ install_scala() {
SCALA_LIBRARY="$(cd "$(dirname ${scala_bin})/../lib" && pwd)/scala-library.jar" SCALA_LIBRARY="$(cd "$(dirname ${scala_bin})/../lib" && pwd)/scala-library.jar"
} }
# Determines if a given application is already installed. If not, will attempt
# to install
## Arg1 - application name
## Arg2 - Alternate path to local install under build/ dir
check_and_install_app() {
# create the local environment variable in uppercase
local app_bin="`echo $1 | awk '{print toupper(\$0)}'`_BIN"
# some black magic to set the generated app variable (i.e. MVN_BIN) into the
# environment
eval "${app_bin}=`which $1 2>/dev/null`"
if [ -z "`which $1 2>/dev/null`" ]; then
install_$1
fi
}
# Setup healthy defaults for the Zinc port if none were provided from # Setup healthy defaults for the Zinc port if none were provided from
# the environment # the environment
ZINC_PORT=${ZINC_PORT:-"3030"} ZINC_PORT=${ZINC_PORT:-"3030"}
# Check and install all applications necessary to build Spark # Install Maven if necessary
check_and_install_app "mvn" MVN_BIN="$(command -v mvn)"
if [ ! "$MVN_BIN" ]; then
install_mvn
fi
# Install the proper version of Scala and Zinc for the build # Install the proper version of Scala and Zinc for the build
install_zinc install_zinc
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment