From 3f1c58d60b85625ab3abf16456ce27c820453ecf Mon Sep 17 00:00:00 2001
From: Wenchen Fan <wenchen@databricks.com>
Date: Fri, 15 Jan 2016 14:20:22 -0800
Subject: [PATCH] [SQL][MINOR] BoundReference do not need to be NamedExpression
We made it a `NamedExpression` to workaroud some hacky cases long time ago, and now seems it's safe to remove it.
Author: Wenchen Fan <wenchen@databricks.com>
Closes #10765 from cloud-fan/minor.
---
.../sql/catalyst/expressions/BoundAttribute.scala | 12 +-----------
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
index 397abc7391..dda822d054 100644
--- a/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
+++ b/sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/BoundAttribute.scala
@@ -29,7 +29,7 @@ import org.apache.spark.sql.types._
* the layout of intermediate tuples, BindReferences should be run after all such transformations.
*/
case class BoundReference(ordinal: Int, dataType: DataType, nullable: Boolean)
- extends LeafExpression with NamedExpression {
+ extends LeafExpression {
override def toString: String = s"input[$ordinal, ${dataType.simpleString}]"
@@ -58,16 +58,6 @@ case class BoundReference(ordinal: Int, dataType: DataType, nullable: Boolean)
}
}
- override def name: String = s"i[$ordinal]"
-
- override def toAttribute: Attribute = throw new UnsupportedOperationException
-
- override def qualifiers: Seq[String] = throw new UnsupportedOperationException
-
- override def exprId: ExprId = throw new UnsupportedOperationException
-
- override def newInstance(): NamedExpression = this
-
override def genCode(ctx: CodegenContext, ev: ExprCode): String = {
val javaType = ctx.javaType(dataType)
val value = ctx.getValue(ctx.INPUT_ROW, dataType, ordinal.toString)
--
GitLab