From 267fdffe2743bc2dc706c8ac8af0ae33a358a5d3 Mon Sep 17 00:00:00 2001
From: wangfei <wangfei_hello@126.com>
Date: Thu, 14 Aug 2014 10:55:51 -0700
Subject: [PATCH] [SPARK-2925] [sql]fix spark-sql and start-thriftserver shell
bugs when set --driver-java-options
https://issues.apache.org/jira/browse/SPARK-2925
Run cmd like this will get the error
bin/spark-sql --driver-java-options '-Xdebug -Xnoagent -Xrunjdwp:transport=dt_socket,address=8788,server=y,suspend=y'
Error: Unrecognized option '-Xnoagent'.
Run with --help for usage help or --verbose for debug output
Author: wangfei <wangfei_hello@126.com>
Author: wangfei <wangfei1@huawei.com>
Closes #1851 from scwf/patch-2 and squashes the following commits:
516554d [wangfei] quote variables to fix this issue
8bd40f2 [wangfei] quote variables to fix this problem
e6d79e3 [wangfei] fix start-thriftserver bug when set driver-java-options
948395d [wangfei] fix spark-sql error when set --driver-java-options
---
bin/spark-sql | 18 +++++++++---------
sbin/start-thriftserver.sh | 8 ++++----
2 files changed, 13 insertions(+), 13 deletions(-)
diff --git a/bin/spark-sql b/bin/spark-sql
index 7813ccc361..564f1f4190 100755
--- a/bin/spark-sql
+++ b/bin/spark-sql
@@ -65,30 +65,30 @@ while (($#)); do
case $1 in
-d | --define | --database | -f | -h | --hiveconf | --hivevar | -i | -p)
ensure_arg_number $# 2
- CLI_ARGS+=($1); shift
- CLI_ARGS+=($1); shift
+ CLI_ARGS+=("$1"); shift
+ CLI_ARGS+=("$1"); shift
;;
-e)
ensure_arg_number $# 2
- CLI_ARGS+=($1); shift
- CLI_ARGS+=(\"$1\"); shift
+ CLI_ARGS+=("$1"); shift
+ CLI_ARGS+=("$1"); shift
;;
-s | --silent)
- CLI_ARGS+=($1); shift
+ CLI_ARGS+=("$1"); shift
;;
-v | --verbose)
# Both SparkSubmit and SparkSQLCLIDriver recognizes -v | --verbose
- CLI_ARGS+=($1)
- SUBMISSION_ARGS+=($1); shift
+ CLI_ARGS+=("$1")
+ SUBMISSION_ARGS+=("$1"); shift
;;
*)
- SUBMISSION_ARGS+=($1); shift
+ SUBMISSION_ARGS+=("$1"); shift
;;
esac
done
-eval exec "$FWDIR"/bin/spark-submit --class $CLASS ${SUBMISSION_ARGS[*]} spark-internal ${CLI_ARGS[*]}
+exec "$FWDIR"/bin/spark-submit --class $CLASS "${SUBMISSION_ARGS[@]}" spark-internal "${CLI_ARGS[@]}"
diff --git a/sbin/start-thriftserver.sh b/sbin/start-thriftserver.sh
index 603f50ae13..2c4452473c 100755
--- a/sbin/start-thriftserver.sh
+++ b/sbin/start-thriftserver.sh
@@ -65,14 +65,14 @@ while (($#)); do
case $1 in
--hiveconf)
ensure_arg_number $# 2
- THRIFT_SERVER_ARGS+=($1); shift
- THRIFT_SERVER_ARGS+=($1); shift
+ THRIFT_SERVER_ARGS+=("$1"); shift
+ THRIFT_SERVER_ARGS+=("$1"); shift
;;
*)
- SUBMISSION_ARGS+=($1); shift
+ SUBMISSION_ARGS+=("$1"); shift
;;
esac
done
-eval exec "$FWDIR"/bin/spark-submit --class $CLASS ${SUBMISSION_ARGS[*]} spark-internal ${THRIFT_SERVER_ARGS[*]}
+exec "$FWDIR"/bin/spark-submit --class $CLASS "${SUBMISSION_ARGS[@]}" spark-internal "${THRIFT_SERVER_ARGS[@]}"
--
GitLab