From 21a6dd2aef65a23d92f93c43fa731c0505250363 Mon Sep 17 00:00:00 2001
From: Xin Ren <iamshrek@126.com>
Date: Tue, 19 Jul 2016 11:59:46 +0100
Subject: [PATCH] [SPARK-16535][BUILD] In pom.xml, remove groupId which is
redundant definition and inherited from the parent
https://issues.apache.org/jira/browse/SPARK-16535
## What changes were proposed in this pull request?
When I scan through the pom.xml of sub projects, I found this warning as below and attached screenshot
```
Definition of groupId is redundant, because it's inherited from the parent
```
I've tried to remove some of the lines with groupId definition, and the build on my local machine is still ok.
```
<groupId>org.apache.spark</groupId>
```
As I just find now `<maven.version>3.3.9</maven.version>` is being used in Spark 2.x, and Maven-3 supports versionless parent elements: Maven 3 will remove the need to specify the parent version in sub modules. THIS is great (in Maven 3.1).
ref: http://stackoverflow.com/questions/3157240/maven-3-worth-it/3166762#3166762
## How was this patch tested?
I've tested by re-building the project, and build succeeded.
Author: Xin Ren <iamshrek@126.com>
Closes #14189 from keypointt/SPARK-16535.
---
assembly/pom.xml | 1 -
common/network-common/pom.xml | 1 -
common/network-shuffle/pom.xml | 1 -
common/network-yarn/pom.xml | 1 -
common/sketch/pom.xml | 1 -
common/tags/pom.xml | 1 -
common/unsafe/pom.xml | 1 -
core/pom.xml | 1 -
examples/pom.xml | 1 -
external/flume-assembly/pom.xml | 1 -
external/flume-sink/pom.xml | 1 -
external/flume/pom.xml | 1 -
external/java8-tests/pom.xml | 1 -
external/kafka-0-10-assembly/pom.xml | 1 -
external/kafka-0-10/pom.xml | 1 -
external/kafka-0-8-assembly/pom.xml | 1 -
external/kafka-0-8/pom.xml | 1 -
external/kinesis-asl-assembly/pom.xml | 1 -
external/kinesis-asl/pom.xml | 1 -
external/spark-ganglia-lgpl/pom.xml | 1 -
graphx/pom.xml | 1 -
launcher/pom.xml | 1 -
mllib-local/pom.xml | 1 -
mllib/pom.xml | 1 -
repl/pom.xml | 1 -
sql/catalyst/pom.xml | 1 -
sql/core/pom.xml | 1 -
sql/hive-thriftserver/pom.xml | 1 -
sql/hive/pom.xml | 1 -
streaming/pom.xml | 1 -
tools/pom.xml | 1 -
yarn/pom.xml | 1 -
32 files changed, 32 deletions(-)
diff --git a/assembly/pom.xml b/assembly/pom.xml
index 1b25b7c6af..971a62f87a 100644
--- a/assembly/pom.xml
+++ b/assembly/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-assembly_2.11</artifactId>
<name>Spark Project Assembly</name>
<url>http://spark.apache.org/</url>
diff --git a/common/network-common/pom.xml b/common/network-common/pom.xml
index b1a37e8472..81f0c6e226 100644
--- a/common/network-common/pom.xml
+++ b/common/network-common/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-network-common_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Networking</name>
diff --git a/common/network-shuffle/pom.xml b/common/network-shuffle/pom.xml
index 51c06b9e5a..d211bd5bd1 100644
--- a/common/network-shuffle/pom.xml
+++ b/common/network-shuffle/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-network-shuffle_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Shuffle Streaming Service</name>
diff --git a/common/network-yarn/pom.xml b/common/network-yarn/pom.xml
index d43eb71aa5..606ad15739 100644
--- a/common/network-yarn/pom.xml
+++ b/common/network-yarn/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-network-yarn_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project YARN Shuffle Service</name>
diff --git a/common/sketch/pom.xml b/common/sketch/pom.xml
index 6f2fdd538f..626f023a5b 100644
--- a/common/sketch/pom.xml
+++ b/common/sketch/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-sketch_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Sketch</name>
diff --git a/common/tags/pom.xml b/common/tags/pom.xml
index 842a1c80e0..1c60d510e5 100644
--- a/common/tags/pom.xml
+++ b/common/tags/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-tags_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Tags</name>
diff --git a/common/unsafe/pom.xml b/common/unsafe/pom.xml
index 08af461f19..45af98d94e 100644
--- a/common/unsafe/pom.xml
+++ b/common/unsafe/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-unsafe_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Unsafe</name>
diff --git a/core/pom.xml b/core/pom.xml
index 1b880d883d..04b94a258c 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-core_2.11</artifactId>
<properties>
<sbt.project.name>core</sbt.project.name>
diff --git a/examples/pom.xml b/examples/pom.xml
index 6b9b94454b..90bbd3fbb9 100644
--- a/examples/pom.xml
+++ b/examples/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-examples_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Examples</name>
diff --git a/external/flume-assembly/pom.xml b/external/flume-assembly/pom.xml
index 9e0636e63b..fb0292a5f1 100644
--- a/external/flume-assembly/pom.xml
+++ b/external/flume-assembly/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-flume-assembly_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project External Flume Assembly</name>
diff --git a/external/flume-sink/pom.xml b/external/flume-sink/pom.xml
index 6b788d7da3..5e9275c8e6 100644
--- a/external/flume-sink/pom.xml
+++ b/external/flume-sink/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-flume-sink_2.11</artifactId>
<properties>
<sbt.project.name>streaming-flume-sink</sbt.project.name>
diff --git a/external/flume/pom.xml b/external/flume/pom.xml
index 1b1105d763..7b68ca7373 100644
--- a/external/flume/pom.xml
+++ b/external/flume/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-flume_2.11</artifactId>
<properties>
<sbt.project.name>streaming-flume</sbt.project.name>
diff --git a/external/java8-tests/pom.xml b/external/java8-tests/pom.xml
index a092393290..1bc206e867 100644
--- a/external/java8-tests/pom.xml
+++ b/external/java8-tests/pom.xml
@@ -24,7 +24,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>java8-tests_2.11</artifactId>
<packaging>pom</packaging>
<name>Spark Project Java 8 Tests</name>
diff --git a/external/kafka-0-10-assembly/pom.xml b/external/kafka-0-10-assembly/pom.xml
index 6c1a120c5e..4f5045326a 100644
--- a/external/kafka-0-10-assembly/pom.xml
+++ b/external/kafka-0-10-assembly/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kafka-0-10-assembly_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Integration for Kafka 0.10 Assembly</name>
diff --git a/external/kafka-0-10/pom.xml b/external/kafka-0-10/pom.xml
index b38de96cd5..60afaa582b 100644
--- a/external/kafka-0-10/pom.xml
+++ b/external/kafka-0-10/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kafka-0-10_2.11</artifactId>
<properties>
<sbt.project.name>streaming-kafka-0-10</sbt.project.name>
diff --git a/external/kafka-0-8-assembly/pom.xml b/external/kafka-0-8-assembly/pom.xml
index 4839ed4f42..bc02b8a662 100644
--- a/external/kafka-0-8-assembly/pom.xml
+++ b/external/kafka-0-8-assembly/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kafka-0-8-assembly_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project External Kafka Assembly</name>
diff --git a/external/kafka-0-8/pom.xml b/external/kafka-0-8/pom.xml
index 948b9f500a..91ccd4a927 100644
--- a/external/kafka-0-8/pom.xml
+++ b/external/kafka-0-8/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kafka-0-8_2.11</artifactId>
<properties>
<sbt.project.name>streaming-kafka-0-8</sbt.project.name>
diff --git a/external/kinesis-asl-assembly/pom.xml b/external/kinesis-asl-assembly/pom.xml
index 09ca2c3aac..df528b3598 100644
--- a/external/kinesis-asl-assembly/pom.xml
+++ b/external/kinesis-asl-assembly/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kinesis-asl-assembly_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Kinesis Assembly</name>
diff --git a/external/kinesis-asl/pom.xml b/external/kinesis-asl/pom.xml
index 3bb80343f0..57809ff692 100644
--- a/external/kinesis-asl/pom.xml
+++ b/external/kinesis-asl/pom.xml
@@ -25,7 +25,6 @@
</parent>
<!-- Kinesis integration is not included by default due to ASL-licensed code. -->
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming-kinesis-asl_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Kinesis Integration</name>
diff --git a/external/spark-ganglia-lgpl/pom.xml b/external/spark-ganglia-lgpl/pom.xml
index 34cbd9a620..fab409d3e9 100644
--- a/external/spark-ganglia-lgpl/pom.xml
+++ b/external/spark-ganglia-lgpl/pom.xml
@@ -25,7 +25,6 @@
</parent>
<!-- Ganglia integration is not included by default due to LGPL-licensed code -->
- <groupId>org.apache.spark</groupId>
<artifactId>spark-ganglia-lgpl_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Ganglia Integration</name>
diff --git a/graphx/pom.xml b/graphx/pom.xml
index c04580cb46..bd4e53371b 100644
--- a/graphx/pom.xml
+++ b/graphx/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-graphx_2.11</artifactId>
<properties>
<sbt.project.name>graphx</sbt.project.name>
diff --git a/launcher/pom.xml b/launcher/pom.xml
index 3db649bd32..6023cf0771 100644
--- a/launcher/pom.xml
+++ b/launcher/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-launcher_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Launcher</name>
diff --git a/mllib-local/pom.xml b/mllib-local/pom.xml
index 3816a15b14..8c985fd13a 100644
--- a/mllib-local/pom.xml
+++ b/mllib-local/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-mllib-local_2.11</artifactId>
<properties>
<sbt.project.name>mllib-local</sbt.project.name>
diff --git a/mllib/pom.xml b/mllib/pom.xml
index c7a9036695..4484998a49 100644
--- a/mllib/pom.xml
+++ b/mllib/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-mllib_2.11</artifactId>
<properties>
<sbt.project.name>mllib</sbt.project.name>
diff --git a/repl/pom.xml b/repl/pom.xml
index 5a288b064d..4e623a6ac1 100644
--- a/repl/pom.xml
+++ b/repl/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-repl_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project REPL</name>
diff --git a/sql/catalyst/pom.xml b/sql/catalyst/pom.xml
index 34ea0a77f1..82b49ebb21 100644
--- a/sql/catalyst/pom.xml
+++ b/sql/catalyst/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-catalyst_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Catalyst</name>
diff --git a/sql/core/pom.xml b/sql/core/pom.xml
index 627558dd32..b2752638be 100644
--- a/sql/core/pom.xml
+++ b/sql/core/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-sql_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project SQL</name>
diff --git a/sql/hive-thriftserver/pom.xml b/sql/hive-thriftserver/pom.xml
index 9ee8d6a36c..819897cd46 100644
--- a/sql/hive-thriftserver/pom.xml
+++ b/sql/hive-thriftserver/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-hive-thriftserver_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Hive Thrift Server</name>
diff --git a/sql/hive/pom.xml b/sql/hive/pom.xml
index d9d8b2e559..2be99cb104 100644
--- a/sql/hive/pom.xml
+++ b/sql/hive/pom.xml
@@ -26,7 +26,6 @@
<relativePath>../../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-hive_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project Hive</name>
diff --git a/streaming/pom.xml b/streaming/pom.xml
index 31a5fe6ab5..07a0dab0ee 100644
--- a/streaming/pom.xml
+++ b/streaming/pom.xml
@@ -25,7 +25,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-streaming_2.11</artifactId>
<properties>
<sbt.project.name>streaming</sbt.project.name>
diff --git a/tools/pom.xml b/tools/pom.xml
index 86a3ba8086..b9be8db684 100644
--- a/tools/pom.xml
+++ b/tools/pom.xml
@@ -24,7 +24,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-tools_2.11</artifactId>
<properties>
<sbt.project.name>tools</sbt.project.name>
diff --git a/yarn/pom.xml b/yarn/pom.xml
index f4a85cd2f3..64ff845b5a 100644
--- a/yarn/pom.xml
+++ b/yarn/pom.xml
@@ -24,7 +24,6 @@
<relativePath>../pom.xml</relativePath>
</parent>
- <groupId>org.apache.spark</groupId>
<artifactId>spark-yarn_2.11</artifactId>
<packaging>jar</packaging>
<name>Spark Project YARN</name>
--
GitLab