From 093c34838d1db7a9375f36a9a2ab5d96a23ae683 Mon Sep 17 00:00:00 2001
From: Andrew Or <andrew@databricks.com>
Date: Fri, 19 Jun 2015 17:34:09 -0700
Subject: [PATCH] [SPARK-8498] [SQL] Add regression test for SPARK-8470

**Summary of the problem in SPARK-8470.** When using `HiveContext` to create a data frame of a user case class, Spark throws `scala.reflect.internal.MissingRequirementError` when it tries to infer the schema using reflection. This is caused by `HiveContext` silently overwriting the context class loader containing the user classes.

**What this issue is about.** This issue adds regression tests for SPARK-8470, which is already fixed in #6891. We closed SPARK-8470 as a duplicate because it is a different manifestation of the same problem in SPARK-8368. Due to the complexity of the reproduction, this requires us to pre-package a special test jar and include it in the Spark project itself.

I tested this with and without the fix in #6891 and verified that it passes only if the fix is present.

Author: Andrew Or <andrew@databricks.com>

Closes #6909 from andrewor14/SPARK-8498 and squashes the following commits:

5e9d688 [Andrew Or] Add regression test for SPARK-8470
---
 .../regression-test-SPARK-8498/Main.scala     |  43 ++++++++++++++++++
 .../MyCoolClass.scala                         |  20 ++++++++
 .../regression-test-SPARK-8498/test.jar       | Bin 0 -> 6811 bytes
 .../spark/sql/hive/HiveSparkSubmitSuite.scala |  13 ++++++
 4 files changed, 76 insertions(+)
 create mode 100644 sql/hive/src/test/resources/regression-test-SPARK-8498/Main.scala
 create mode 100644 sql/hive/src/test/resources/regression-test-SPARK-8498/MyCoolClass.scala
 create mode 100644 sql/hive/src/test/resources/regression-test-SPARK-8498/test.jar

diff --git a/sql/hive/src/test/resources/regression-test-SPARK-8498/Main.scala b/sql/hive/src/test/resources/regression-test-SPARK-8498/Main.scala
new file mode 100644
index 0000000000..858dd6b5dd
--- /dev/null
+++ b/sql/hive/src/test/resources/regression-test-SPARK-8498/Main.scala
@@ -0,0 +1,43 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+import org.apache.spark.{SparkConf, SparkContext}
+import org.apache.spark.sql.hive.HiveContext
+
+/**
+ * Entry point in test application for SPARK-8498.
+ *
+ * This file is not meant to be compiled during tests. It is already included
+ * in a pre-built "test.jar" located in the same directory as this file.
+ * This is included here for reference only and should NOT be modified without
+ * rebuilding the test jar itself.
+ *
+ * This is used in org.apache.spark.sql.hive.HiveSparkSubmitSuite.
+ */
+object Main {
+  def main(args: Array[String]) {
+    println("Running regression test for SPARK-8498.")
+    val sc = new SparkContext("local", "testing")
+    val hc = new HiveContext(sc)
+    // This line should not throw scala.reflect.internal.MissingRequirementError.
+    // See SPARK-8470 for more detail.
+    val df = hc.createDataFrame(Seq(MyCoolClass("1", "2", "3")))
+    df.collect()
+    println("Regression test for SPARK-8498 success!")
+  }
+}
+
diff --git a/sql/hive/src/test/resources/regression-test-SPARK-8498/MyCoolClass.scala b/sql/hive/src/test/resources/regression-test-SPARK-8498/MyCoolClass.scala
new file mode 100644
index 0000000000..a72c063a38
--- /dev/null
+++ b/sql/hive/src/test/resources/regression-test-SPARK-8498/MyCoolClass.scala
@@ -0,0 +1,20 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+/** Dummy class used in regression test SPARK-8498. */
+case class MyCoolClass(past: String, present: String, future: String)
+
diff --git a/sql/hive/src/test/resources/regression-test-SPARK-8498/test.jar b/sql/hive/src/test/resources/regression-test-SPARK-8498/test.jar
new file mode 100644
index 0000000000000000000000000000000000000000..4f59fba9eab558131b2587e51b7c2e2d54348bd1
GIT binary patch
literal 6811
zcmaJ`Wl&t(md1iK5TudD-2#n6aCdjt;0f-ojk~)Cg1cLA2^N9|cXyWrCYk%DZr+`F
z^PL}O@2a!cUUh2ex0GaI;jo|(5fPy(9Hu3p{s0yf9F)AcnlM;eL4rwMSV3AsTvd%x
zUgG%+6x5ac*r=Q=m~jeK7W`&nY_eX3d4_F$=W+}@EIlqiPA|;>4S=D#Qn`$*z)BE$
z14ITmtB$HfGOGofrfh%2R1t&lx8=}*is5iSQd<<8QE$1Rm60D$2){-A&e0W~?$I{E
z9X>Fi0U+gM!ezpRQj$eLWT8oGwELwV88p<d{eMy#^Vb*h9-?-3)}q$NPEM4JCcj_V
zYPyO*W%OqST`ipy+17~V4*zQrI$XPjz<1Ety6+hht{rq=x3nB{F4<80ATxvpW=OsB
zX1kEY+dH<cX%IuQF`vxhb~4|6GI#a+`Fu;%&9}-joZgpYY)L0imr6s)98&1qT4E`)
zT(O_x*}X*{Txa%1{6l8}E_n7UZo+|2QCUBS_*&#1gX-)Z=6v0ZnG6HXG6T15Swt~0
z-K%IC(BMm=ZeVQwr-w3#Mu?Gq2;Net@E21}!H@IQAf6-Sv^+hVk%HpGvc|D>)Zk`3
zoy1!W350DZzI{rPQTs0z`^dqW!YmE*;x?jaL6eUqDR??bD$=~BTF5I=Rp(S)lo%ct
z#raLIKI%fFybC*|r!$L`>HtKkv3jH*IWM>A*1n;pQ5AQKj|yQ-#&YFN1BXu_QfK`v
z&UecA*p5PUz#}UXLUQ-B1>sP<`y|gnDBDX&b^o~e4OO&itSD;;2G)&)X%x?5Lllc-
zrj-%7?!ulpy#rBXU%xe!@fgdsA;!Rk7NQXV&5BV#aST9s)528d;xFqi^Hsj;xMR;u
zwES{V+5r~%9$HXdJ;8XZc;{^<sEy!>cB3`Q7bOhC!1!EkkJ0UEv-lGa6ER$q_*fg0
z*|Gh`d-M*QU;{?a+NS=XeEP~m?|Mh2_2Lf)!`d<zsuFaqUVaKI)7Tc~_n)b$(yQ!l
zQ3a_-uRpPT!NaZ}o>x~El2w2V5a!!LkAp|z*0Z{tF)L5vMlLg4I~yW$onI@W>eJj(
zhuLBdkx7)>U))|3PjB`Rcz%gN@^S4)P0&~(FTnVII!m~7JGJN=)8p;TqtSQrnT&iQ
zo<PL14^$h}Fr5?|m-=;3>WY&RG(^OMjpT|Hb)FgZ40*vyG-URSDgD9S`>>B!K*^He
zj(Wwx$J0cQQ;Lu!i(5)_0aB#3_sMAHRLv1G=q3N=I*XTJA=R>Ou4mx=N$Wl3;JlpN
z9RQ>Lcy&B6REQ)>%x`^wT{>zTg^Az*$zTQ~1}JweA)S-DT3F<<N<Fv;J8R4|?*UJd
zly0bR)2ArlA6^?y2~|hVMap~Gh-z%V!2b3z**UyyN?0f;8iYT6to$E=0r1<$jIC_{
z@-2O3eLGBL^z83wDagpq$jB<wi;Zbblx;n5A7r0uA{$i5P{o<mJzCaN7`~rotPDU9
z{E`Ij*MkJRb2rdfCK5nEJIAwhZYNuF$KAcNGeM|zx@F0@$K@MrAxQMAmwx%!C#S3T
zZT9B1FytcCrGnw+%Ug)Noi0Wp6P1!MPHCp1Zl_o7csyV@kG6<x#0^crO=3U*4A9ve
zubLoII-3JUmdEQx&eKX@A^Gb!u4ZiED&m4@A_i6yrO#IIPsa=Brot<>tfRIj1~cW8
zB$~0s;!SndNyj5LR?BM%s$NU*^*kjN!~@AcCaM?@=b$F3v_Z<B?`F<)w!8p9`oyY$
z2=Y2*F&^&OW0M%eyyY%F{x{BWH}10>Q4QqgJDUL>PQ@d+jp;T;QRF5kp|q%3jwkXj
zl?(=!nOR4bmhO&icDgz-D2b=T_>jw<_Eo{75QqK8tGSJ|F{z4jx;SyAM@=S)PKD@#
z)eM``xF9}QY``1lVN=>~=rTv|zy?0f=J|bFq}DU|04xl^OZ-e1k+;32aGw$0M3&Qh
zq1ee|7qE$+SbPM(Y+hE-^(?EFpjCCU)>|;l;}~9G_M2ZS0xG&t;5KQrNFRC%9X&=Y
z<e<7n`2{}Ha1I~o%{73ukH1$;mwe{HFqv7_BccjZ7{4hD-OOL`x5Zf5yCFXQipcgb
ze_G5xQwheuN9Df^r&4o8m0%uQ&`q<wT%3M{J|Ip=NCS~T+Mm1z6{gUXN(hJ4qzg=#
z&hRbJ3>nFXdwtI1$mA&v?**D@()lvZ9G_--?0Tyx`@nA|z2Tsh9xq6VRjwG{^=#$J
zW%420X|nUj(PzJBWGK1bJvfGgda+hLIjlw<c_@+fLAH}%9LD!Wh3AVsZ2X$I{!~Vl
zI}HUmzFOctf~0;7dv@te&&E7#WTwWT0!Du!p)Mnb-Z(PmmPM?p!%%T{yw#6}nZbn#
z8g^<o+%U^M+WOTP6B9rMK~jfa%v8b)n{lS&q08w_n)pX$r6}4mE8m@}17G)jSfDh$
zm>Gm10;KMZEOxx1Qiqv4PD5R^+VUkbOLB%LBrx=#MNb)r%T*|z{-eb$W#g9oBKKfL
z)G+HP>zr<t?H$D8Q9I~NLE+kA6HJcqm;{Gp4?waoCm>_&rVN{TODaL%$FLROil{xJ
za6s=<9+A;dJ9m9<+2Xfr6<flJGKz}npnR;Xg}WrWJOt|$QIW+`<|x&sHIUCTwfH5d
zmSTyNhB}Oa2j&g#rdnM}c3Jh<<2d2yLwJi#vd_oR8!^`t#ohPx0xsDU4lENf6=>zf
zg?j`hg&P9e4JgcIa-N_MW)GGHey4^0Ss9y}US`g2E0Un8gqRxQS#lkNMv0@3EQ@=1
z+JpD(3gLuag-ptm>2i1Bx6Z*XZ}5@mroIFwkw?*W6ZR7s2k%q>Cew3)wa7m+%nNfS
zt-n9SCmp$--LE@SG=iKhIdKWT-DXATn-Wy#jAUe6OybiDa3vbLd3>UIEM{2N*3$sS
zJ96&2>E<qTkE|w1_e^l*OnL@~caCgEY&FqmcRIy2Mk66a#iG<x6g>JbB(fwvNzBg}
zXOOhp5jZQ1zydx+l@KN#e0$BxmYmVooVgm=F>HPR2?C*$=3;;(<sN9ZE82KDJ%}tn
z(001*p*ZYf9uDgWHVa^C+7)YSAIbYUF7>X~mK<&kTZCuU)va%j0VpCsd+-Egg=S|n
zk=r5cn5Vg3c$=mI`58@F1-(P+=G^VIO3L~W<19TYu`z7^-8Hb+ZVGGFrtKo{e4kZp
z>5m*$y-$}H#~UKSd;sHUL>Vcw36;o;h(pfn4<?7L&yLVXQ;(*_IGbT{suZ5vRV5#_
zshOOP(y9-(urt^6FDING_*a^x-hHgCW1t#c)t(YCV!dpeD35oT98<BClv#A&)rLPZ
z^ckyd7a*LsP+(;|7*1g}o93hO9B#3U#rOOoP@NDyW-TlvSRrewN{l`pQQ&xyB$h_Q
zrW?F7Td0y79Pgt%TUDktDcp>oTPCn~HSMam2Raz2h;S+F`kLmEVumYjmMir$bX8)6
zw=-^|lda`UB)Y4lqM$2id~93lcs34S|3!(c>Z|MfX-R=5`)VB1=yad>6|I%*g)O-X
zB|LSU<mD-e=BEX=)P7It5R%EH*d!@42U=mR_D!V_E~nFUh=<e6Hb!mUsp<=ZMZ_0k
z%M0(bXe!k>A{>5!VBAV87E$sAeLjmAMA0LDOuQ+r<nJ10x#T}02HKD<VNBMl?sO0e
zh8j`D4GfjMl5$G)w3Uby%4y%Np@(cr5St$PgFps#Epfy}*WED(&;16u``d#=$#4S{
zJ2S&S!iqm`14#P3O}3;lrQM`Qu5Z<R{4Q@P=qH(*)nf_Oto311Z@|FmzJc|H2A4P}
zL%S@j8$Reg%e-0fRQw{nP9;Y18V4ENwn{@NUTCt;rkc*SeHtU(&f%;?A^1?lx7~CB
z*w*@7N5U6+g*xDU4<ye__P5Z};Tq*8p@u$wIM#FJ!QU_#X|vRBG7LmG{TA|8GKJoH
zx{9j=3hd(s1dugo`stKxkU36~V4ZWm3ZVj7PDm)RYYK2v)NpyuZo1G0$jau$-T{h4
z_$5dmWl>M1(EW{YJ#j_EO5L72d`mbYT>Kz|TvFP=lL~44?4F2*`eMr#_#;jc$8UVf
zB%32zTpZJ|TJPg$-si_i)f5I`Wmsb1Mn2X;`%YROlJAcf;=>aAD#|8bJ|5^4cDaI>
z-pV{IZdxe_=DSdI^TYU50$Y{KaAR)lJG{&0Iq{3YKhU9|6JLM%q`RY5T19f84pTLH
z)VQD4A1izk7)z?qt;h6MIMFBo-ZD`9a8J=V<2cZxB^Em85rZP3&H2Vs22dl@y$ax0
zpD)+xjOs$kI)mu7N}T~gs`o?$Ec>4cGaSBK28ZZwli_Rq#6vR4wGOL!ovF2WQxD{S
zsaXlCotl-!EojYkk_xn0I1uq_4^vj42W#N#)S{+qJi~aUx~+KVj4L)SPK$BJw#zU3
z3A*WBP*4fu<b0jIE!}TVGBVb4Y3<9IUH3oSwcp#H8P9;@IiAuZmWj(}gU`Vix7t3(
z+u<8pbslLDobQk)F2ojG@q1RtDF|TAau!B<({iF)o4tmF#MilacG`%j+d!qT@?^%#
z!|7Hk*^j<5$qROwoq3VmzT9N#gC2U1hwaARA+yEd8QE2Hu8B<bQ+VrMsJe-EZoDnU
zD`!qYXDvQ=3GuFK4nx1}L;Z5e?sX9i$NG26Q~zv{N`IVLl~TR=671u-UAI(cCFTQa
zZ+B)`<kyP}7i$OzCu@UTU-88~EAsSEKW7Q~KSQeXpTI3$tOAGk%wL6iR&&v>^{~7H
z7_4jVivx`bOKEX`0KLzX$<Fb*il{NNuQ%Ky(Cm~-^z9_gUT%^Qc;2ja<XnP5Hgt9c
z5G2XbyKYkvldZMh1utL^b-7vK1Z`7)nzA#ViNuB35)SBWeMJ}1aIzhZ_l=@~qDNWb
zW%d!>8ows79bJ9Qfvb8`;US8cZkY*KJ>;cMKJlQ08`%jwzLsZ$Go<y>afim`nfFl0
zwZ=gX1Nuq4%l30kcoWRvgIxOg+xn`1G|V+T#ErCmu#8cZ%{AvUh@lTq<>K&@&09C%
z3A&?y@Cpg~+ps&-hswv?{&+yf=MXUaa|scOQ)pbq(iWAkv8-*dL{I*Neg0?IE8^7R
z(B;-pLeKk_aZ#AuER&_(iBBhpZjPZ}ue$1epLsUWJqOuuq;ZPIrGAow9{GPTCK2~p
z8U%gE@`5EKAaF;`4Sj|ms|eriG3lLWNPVD@Y9~G=G4g_q<y+R}@<c_mYNPdYOtHK4
z2ol`dKz$BnFHiEb(6GFG6?Ars2>%iiTBYQU8hC)3w&1pvYLou5NjT5Mvo6E-qFeI}
zr2s7_xV~~KiM992=p6VG#?tq`JN2BRNi09xCH%u_H$U$ETPc!4j}X=ptZqO5q5?sc
zAG+)!&8P<Ex}}dZmPb&hM*9T!q+GYC_d#20-Q(-cN+`Yvvw}^Hbax&#r&pXi0(PpW
zuWcfN4e>a|?i;6u&#!xiRQhz>#pAc3o)LZ*kF{k*k<Um_P*K0S_W#_{<NvGOprmy6
zus1VtG&6R#b7Y}p`KyYIR+CkoR>FE#utEY0!`1RZ3eb!E(S^myio%Gp9f}9U1ER~9
z&`ISooG*=vUu52Lwb|=E6%tO$^P*Trm^zT`dGGPwbzC0Z-H|}eDU(IbLQdZ6EZAxn
z+l7C<ns4BEC6<OHw}H6Q978mU;xbit<0GNYL;K1HlErQi?EsM*`<Ry-XL}hR$K+d<
z6YiAH+si+7lyBEgGq{-_0d0!MqyzpWzrd*Ra-&x7vvw6d0GI47mN(+kY(@YHH<$y2
zAi~Cf$kp{V!T=0VwgpwKDzQYhb1(NG8rRHKx#y@lh@qpb6C(#IL7MQ85i<uMEtoAw
zC+2-lFqQSAdu1)L9nP!@TKhJnh3)Jr%+kLiJXW3hJ1prOVk1v<)ikmwh=Cr@B&vuY
zYpXZpK`iHJM4crvG+_&4o}I6e``VkM)VKwOyRuZg3X24z*fTXL?i+dUwR}-r8ugG~
zojxxE@G+w9LrP7SD83?6{fkFSpn9)6T3nz7Tv6mU-!geRAO}e81%ur|Y05MO+4%fT
z6x61nJYhb-yZJ6ggP)oos|$=D)5wI|RJB;uh|58cvX*RmbQ@0JJG|$l#<S2y=ccQv
zb7is>btBPw2T8s~i@K~FWYD}LUu#%hx&W@V7H_>;zT=?hyJ^`xM3`^<;V!^nn<%G`
z`3{w?D(#2LI$7YCC!DpI_RHSOR}vpaz32-~aMSL?OYLaUH+^ExxtrMB^$+t{(7@*O
z>nu6UCh$Nlp?GD$rIx8SiA=?r1yPGfvq=c+T8oE!a+k|$5oi51HoYOEehHEB{D67_
zyX!kOcsqB+`f@_o2lgS0Y*9T$pn(x=_5Eb(yN3^^9;Tc%BX`Z0jeh@4Q!$OI^hf<_
zhU{Pce>RQ$KQ{d@eoEuc2`CBjp-)Ym0H7<&*F#~L4&{MhS(;S4olQwo0=THjEFKt0
zvd;PsOqn6qtMpbML$3`t$A(4uM(+21D5rPuBk`q7^a95%?_BSmx_k`3H$P4O>V8m-
zczuB-N3$sO#X^V-+@GR9AgR`~hHr`PT{o2HNeCswEIC?@&%h<EZapbb-woX-Ut_hy
z1+G|4*Pz@92V}Tk(FHu(+JQnM;v%5%;oc9?GSrX@q-Cv8?(l>pA0)hS^SA}l5c+75
zkYx<OL?$}zw)K__t&lMYiy6rpuGW<hxLijS?m33oi0kw3Nl04LWbo8}I@_O%A!_Gs
zdQ}@GRlhvQ(fae!y>40jlz0$Op=RZt+|9EzLfKG}LOcs>t=P>{{AjvlqFdz~exWt)
zpU&y<sx~EMCkKMj?-_8Tu704ZMw(H<xXs<l0zqA%tf4lSnFoCVWzXoXgtMUQtU8;V
zz>IE=C+DM>u$?NGb`_O9z79}VV;X#GlSvKRgHEmT_$tFvB9h&~P94a*$1+uJX7!G~
zNg5blM(r9rrIED6XisHuFdk^`oqayEBS?=dH1HbxgU}~VO-fp~9=Ry|EzeE#%%x!a
z&)tLWH`XZ(XBtxh3OKnWDk<X4-7<zu5wqt;h-m9%0U@j5#7mrBa^O_e8cCssS5tkq
zUg%HX8xb6ojP71gOfU|OvArC`j1G);xRv9u5DlFhtaAnGh8!A@0!~|E^Awe%cJytA
zXMmqdvu8v3ZFt;JhIVRsd)Nj%oO*-KG8IWO5nRgGrUqSTXym7LNL1d4&Q2C?ScpPf
znfo{lOi6Cb^p5COu@uv!^<3#lSg;Z&TQs!Ar6v!FfVxRrne6Z|gBVBiTjf+o@xv)l
zCPxxbI7o(oZ#X7Z*b3VXSn*D|CBJ8WED0gQZj?$y8pXl3Zx?UAPHf_=;Dw1!)`*a8
zNbV_#zyM)m(1w<*^NqA@J63OSaf0vq_gMIH`@{$ItZy?xgGL<P5O7VKO1U3-`P~P+
zHrId#9sKw`9}`bmE{(@Hx{)3m{~$iAQkDEL;U4k15VsEldhd&=NWLrRR>=22B1SKB
z790Fmu=uF#IZt6LwvYJYyds_+Br3gu)j7Eu4%m~-FT^T7xx4QX2yLQ91lcCJwZnFH
zW#$sF+?IHneP2(?e)H@(Q^}+#U#BWAhYM`B=<xWu=9%jg?`qgn{>EVN!zE0$r-P)^
zgLB3xL7;n3EP~t2I!oznmRwa-mdrI3`tU^_`$|9@9j8n!_!%@RZ4fbZnG8{Ks3=-a
z6B_MRgyjg4^v;EKQYAym6TXbb+~hrUsvE2%r(9d+o(FW9-XvkS3wh^rVSD#|)JWDi
zC&~@02g<3&@{eIgQ|_=GB<+F{a-Ym7)|^9%NJe8(4-~8<<iC5+RFW`nlX@@IIS-kD
zveT<%N3tKJ5SdY+=oBOZ4LK0WhCg?s5rWN_{JyZms3N|cq7J{)Qo}-*w>+P*m3wDp
z>H!@+t;L3}jcb)5R^i_=-{g7XW3VI;tlv4k53<Y_nXj!(bWe+D^fNva8fVWO?ivml
z&Zi@kAJ1#{mjrNe2Tdn(sdgu3y9{&{`ES5XtcY>?PdpB`;c>lXQ9wJiu(!fbMJTo}
z^0z>CudQ#YZStR2l(n|Q%!H71$6BLd3vYp|Qw{C5h}vc%WZiMkl;6`>cf_KBVvPk_
z1^OjRwsa_}HcTWA@nO%A1k8?o3vS;}408^<DbUZUG>2m<>+L<!lNuftSvJ+DUZ6C}
zZPcd-+WX)rwX`U~P)5&rv6UmPTPT*j{#>&*46aUy`n-OqdF*r(cnt8CU$ML3x3&LK
ze!c(S+?8Ypd7R^~Fdc^SJ5)o%U_t#o2>El`@Ou#Q@Ayw+k$+10lTZCUnfM!xzn1@d
zPVwjY->mDO?AmYE^>5()Qt59F_Rn*_xwk(HtKZz)-;jm>w|oCeKmR=bXAb*aef^Cv
t^uMnCziY97%K7sL|IT=SLl5{bIsc=;t6zFSLBaoee1EZt2zbAD{{<gSK<oej

literal 0
HcmV?d00001

diff --git a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
index 7963abf3b9..820af801a7 100644
--- a/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
+++ b/sql/hive/src/test/scala/org/apache/spark/sql/hive/HiveSparkSubmitSuite.scala
@@ -35,6 +35,8 @@ class HiveSparkSubmitSuite
   with ResetSystemProperties
   with Timeouts {
 
+  // TODO: rewrite these or mark them as slow tests to be run sparingly
+
   def beforeAll() {
     System.setProperty("spark.testing", "true")
   }
@@ -65,6 +67,17 @@ class HiveSparkSubmitSuite
     runSparkSubmit(args)
   }
 
+  test("SPARK-8498: MissingRequirementError during reflection") {
+    // This test uses a pre-built jar to test SPARK-8498. In a nutshell, this test creates
+    // a HiveContext and uses it to create a data frame from an RDD using reflection.
+    // Before the fix in SPARK-8470, this results in a MissingRequirementError because
+    // the HiveContext code mistakenly overrides the class loader that contains user classes.
+    // For more detail, see sql/hive/src/test/resources/regression-test-SPARK-8498/*scala.
+    val testJar = "sql/hive/src/test/resources/regression-test-SPARK-8498/test.jar"
+    val args = Seq("--class", "Main", testJar)
+    runSparkSubmit(args)
+  }
+
   // NOTE: This is an expensive operation in terms of time (10 seconds+). Use sparingly.
   // This is copied from org.apache.spark.deploy.SparkSubmitSuite
   private def runSparkSubmit(args: Seq[String]): Unit = {
-- 
GitLab