From c9acf4550d39426e1cb187734c1440432817a8f7 Mon Sep 17 00:00:00 2001
From: Amer Tahir <amertahir@gmail.com>
Date: Thu, 30 Aug 2012 18:06:48 -0400
Subject: [PATCH] minor fixes
---
.../java/net/floodlightcontroller/firewall/FirewallRule.java | 4 ++--
.../java/net/floodlightcontroller/firewall/FirewallTest.java | 1 -
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java b/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java
index d56d6035b..27cb51251 100644
--- a/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java
+++ b/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java
@@ -62,9 +62,9 @@ public class FirewallRule implements Comparable<FirewallRule> {
*/
public int genID() {
int uid = this.hashCode();
- if (uid <= 0) {
+ if (uid < 0) {
uid = Math.abs(uid);
- uid *= 15551;
+ uid = uid * 15551;
}
return uid;
}
diff --git a/src/test/java/net/floodlightcontroller/firewall/FirewallTest.java b/src/test/java/net/floodlightcontroller/firewall/FirewallTest.java
index d526640f2..43cf08f0f 100644
--- a/src/test/java/net/floodlightcontroller/firewall/FirewallTest.java
+++ b/src/test/java/net/floodlightcontroller/firewall/FirewallTest.java
@@ -5,7 +5,6 @@ import static org.easymock.EasyMock.replay;
import static org.easymock.EasyMock.verify;
import java.util.HashMap;
-import java.util.Iterator;
import java.util.List;
import java.util.Map;
--
GitLab