From 58af7f0a495d3de3f00d2034ad51d2dd888112d8 Mon Sep 17 00:00:00 2001
From: Saurav Das <saurav.das@bigswitch.com>
Date: Fri, 11 Jan 2013 13:31:47 -0800
Subject: [PATCH] IPv4 octet range check
---
src/main/java/net/floodlightcontroller/packet/IPv4.java | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/main/java/net/floodlightcontroller/packet/IPv4.java b/src/main/java/net/floodlightcontroller/packet/IPv4.java
index 81d2c6c07..76a140ed0 100644
--- a/src/main/java/net/floodlightcontroller/packet/IPv4.java
+++ b/src/main/java/net/floodlightcontroller/packet/IPv4.java
@@ -403,7 +403,11 @@ public class IPv4 extends BasePacket {
int result = 0;
for (int i = 0; i < 4; ++i) {
- result |= Integer.valueOf(octets[i]) << ((3-i)*8);
+ int oct = Integer.valueOf(octets[i]);
+ if (oct > 255 || oct < 0)
+ throw new IllegalArgumentException("Octet values in specified" +
+ " IPv4 address must be 0 <= value <= 255");
+ result |= oct << ((3-i)*8);
}
return result;
}
--
GitLab