From 4d528e4bf5f02c59347bb9c0beb1b875ba2c821e Mon Sep 17 00:00:00 2001 From: Randall Sharo <randall.sharo@navy.mil> Date: Fri, 25 Mar 2016 12:15:35 -0400 Subject: [PATCH] Fixed bug in FirewallRule.isSameAs(). Code was not comparing dl_dst correctly. --- .../java/net/floodlightcontroller/firewall/FirewallRule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java b/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java index 6b66f922e..4c8f9bdad 100644 --- a/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java +++ b/src/main/java/net/floodlightcontroller/firewall/FirewallRule.java @@ -249,7 +249,7 @@ public class FirewallRule implements Comparable<FirewallRule> { || this.any_nw_dst != r.any_nw_dst || (this.any_nw_dst == false && !this.nw_dst_prefix_and_mask.equals(r.nw_dst_prefix_and_mask)) || this.any_dl_dst != r.any_dl_dst - || (this.any_dl_dst == false && this.dl_dst != r.dl_dst)) { + || (this.any_dl_dst == false && !this.dl_dst.equals(r.dl_dst))) { return false; } return true; -- GitLab