From 9f4e07cc4cfb65b74026857e6ed8428bfa70c6ba Mon Sep 17 00:00:00 2001
From: Abinader <abinade2@illinois.edu>
Date: Mon, 30 Apr 2018 16:49:23 -0500
Subject: [PATCH] added info to buglog

---
 student-distrib/buglog.txt | 71 ++++++++++++++++++++++++++++++++++----
 1 file changed, 64 insertions(+), 7 deletions(-)

diff --git a/student-distrib/buglog.txt b/student-distrib/buglog.txt
index f320b78..36a2298 100644
--- a/student-distrib/buglog.txt
+++ b/student-distrib/buglog.txt
@@ -1,4 +1,3 @@
-
 ░░░░░░░░▄▄██▀▀▀▀▀▀▀████▄▄▄▄░░░░░░░░░░░░░
 ░░░░░▄██▀░░░░░░░░░░░░░░░░░▀▀██▄▄░░░░░░░░
 ░░░░██░░░░░░░░░░░░░░░░░░░░░░░░▀▀█▄▄░░░░░
@@ -21,23 +20,81 @@
 
 Checkpoint 1:
 
-    Send_EOI logic
-    - Basic logic mistake in SEND_EOI function for PIT
+RTC not interrupting multiple times
+- Basic logic mistake in SEND_EOI function for PIT
+
+Keyboard handler didn't return to correct place
+- Didn't know about the need for wrappers. Added keyboard handler assembly
 
-    Keyboard handler didn't return to correct place
-    - Didn't know about the need for wrappers. Easy fix
+Several Page Faults
+Fixed by initializing paging correctly.
 
 Checkpoint 2:
 
+Page fault when filling buffer
+Off by one error in condition checking.
+   
+Not able to read very large file
+Mistakenly assumed that datablocks are contiguous (RTDC!)
+
+Not able to read next file when reading directory
+      - Not updating file position
+
+RTC Interrupting too fast
+RTC Write flawed logic, interrupting setting frequency
+
+
 Checkpoint 3:
 
+Can not return to parent program when halt
+Storing the esp ebp on a designate function instead of storing inside of execution syscall function 
+
+Can not accessing PCB according to the hand calculated address
+Copied PCB to the wrong memory address (at the end of the stack instead of at the beginning) 
+
+ Not entering the program correctly and causing paging fault
+Entry point calculation error
+
+ Page faulting on spamming keyboard
+Caused by a buffer overflow
+ 
+Shell restarting after halting everytime
+Not distinguishing between root shell and user shell
+
+No command would run
+Error in parsing function
+
+OS would triple fault when doing halt
+Caused by off by one error in syscall jumptable. Solution was to decrement eax.
+
+
 Checkpoint 4:
 
+    Fish frame 2 does not appear correctly
+    - Clearing the entire buffer instead of single character in read_file.
+
+    Wrong output when pressing alt in terminal
+Simple error checking condition needed
+
+    Wrong output of pingpong - an additional newline was printed
+Deleted \n at the end of buffer and printed it instead. 
+
+    
+
 Checkpoint 5:
-    Fish stops running after running counter or pingpong concurrent and swtich
+    
+   Displaying the contents of one terminal on another (leaking to other terminals)
+Created enter_flag array for each terminal, enter key was being read by all terminals therefore pressing enter in all terminals.
+
+    Fish stops running after running counter or pingpong concurrent and switch
     back and forth
     - mistakenly use visible_terminal instead of running_terminal 
 
     Characters oddly disappearing from terminal screen when typing
-    - Not flushing TLB!
+    - Needed paging remaping and TLB flushing
+
+Exceptions handled but would get stuck
+Fix: needed to squash user program after exception happened.
 
+Shell would not print starting prompt when initialized
+Fixed by adjusting clear to clear correct video memory.
-- 
GitLab